Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DVec and all uses #5279

Merged
merged 7 commits into from
Mar 8, 2013
Merged

Remove DVec and all uses #5279

merged 7 commits into from
Mar 8, 2013

Conversation

alexcrichton
Copy link
Member

Closes #4985 by removing the dvec module and all use cases throughout the compiler.

A number of uses were directly convertible to let mut foo = ~[];, while others in hash maps and some fields had to be converted to @mut ~[T]. A small number of DVec instances in fields were able to be converted directly to ~[T] without the @, but this was a difficult thing to do.

@brson
Copy link
Contributor

brson commented Mar 8, 2013

Superb. Thanks!

bors added a commit that referenced this pull request Mar 8, 2013
Closes #4985 by removing the `dvec` module and all use cases throughout the compiler.

A number of uses were directly convertible to `let mut foo = ~[];`, while others in hash maps and some fields had to be converted to `@mut ~[T]`. A small number of `DVec` instances in fields were able to be converted directly to `~[T]` without the `@`, but this was a difficult thing to do.
@bors bors closed this Mar 8, 2013
@bors bors merged commit 62651df into rust-lang:incoming Mar 8, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 23, 2020
Macro use sugg

changelog: Add auto applicable suggstion to macro_use_imports

fixes rust-lang#5275

<s>Where exactly is the `wildcard_imports_helper` I haven't been able to import anything ex.
`use lazy_static;` or something like for that I get version/compiler conflicts?</s>
Found it.

Should we also check for `#[macro_use] extern crate`, although this is still depended on for stuff like `rustc_private`?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants