-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #52433
Rollup of 9 pull requests #52433
Conversation
Enforce `#![deny(bare_trait_objects)]` in `src/librustc_errors`.
Some can be avoided by using remove_entry instead of remove.
…atsakis Deny bare trait objects in librustc_driver Enforce `#![deny(bare_trait_objects)]` in `src/librustc_driver`.
@bors r+ p=6 |
📌 Commit 6626522df79ead3f0c1dfed4dcf47774f92e0d94 has been approved by |
⌛ Testing commit 6626522df79ead3f0c1dfed4dcf47774f92e0d94 with merge 0cb6d941828b7099c0e22f0b9976720ce6331621... |
Previously we'd only do so for stage 0 but with keep-stage improvements it seems likely that we'll see more developers working in the stage 1, so we should allow enabling incremental for them. Ideally, the check we probably want is to only enable incremental for the last compiler build scheduled, but there's no good way to do so today. Just enabling incremental in all stages should be sufficient; we may be doing extra work that's needles -- compiling incrementally something that will never be recompiled in-place -- but that should be sufficiently unlikely (i.e., users either don't care or won't be compiling the compiler twice).
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
Oh dang... yeah, combining the PR that fixes miri and another PR that breaks miri by renaming half the things into one leads to trouble.^^ EDIT: Ah, actually the renaming PR landed first, but they were racing in the queue. |
AsRef doc wording tweaks
💡 This pull request was already approved, no need to approve it again.
|
Don't fail master pull request when an unrelated tool is not test-pass.
Somehow this doesn't really seem to be in the queue? Let's see if this works. @bors retry |
@RalfJung: 🔑 Insufficient privileges: not in try users |
@bors r=kennytm |
📌 Commit 82525123b42cf877d8548fc9c02a68fe61b2c9f3 has been approved by |
⌛ Testing commit 82525123b42cf877d8548fc9c02a68fe61b2c9f3 with merge edd38d0814344f5021c91abeef628f8bb02c3c62... |
💔 Test failed - status-travis |
📌 Commit 8538063feb4a80b56b8102f87fa0fe98eef83464 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
update nomicon Will this trigger a website update automatically or is that a separate step?
Deny bare trait objects in src/librustc_errors Enforce `#![deny(bare_trait_objects)]` in `src/librustc_errors`.
…arkor Reduce the number of clone()s needed in obligation_forest Some can be avoided by using `remove_entry` instead of `remove`.
Calculate the exact capacity for 2 HashMaps
…age, r=alexcrichton Enable incremental independent of stage Previously we'd only do so for stage 0 but with keep-stage improvements it seems likely that we'll see more developers working in the stage 1, so we should allow enabling incremental for them.
Block beta if clippy breaks. Also, don't fail master pull request when an unrelated tool is not test-pass.
…er, r=QuietMisdreavus Pass edition flags to compiler from rustdoc as expected Fixes rust-lang#52357.
📌 Commit c0db1aa has been approved by |
Rollup of 9 pull requests Successful merges: - #52286 (Deny bare trait objects in src/librustc_errors) - #52306 (Reduce the number of clone()s needed in obligation_forest) - #52338 (update miri) - #52385 (Pass edition flags to compiler from rustdoc as expected) - #52392 (AsRef doc wording tweaks) - #52430 (update nomicon) - #52434 (Enable incremental independent of stage) - #52435 (Calculate the exact capacity for 2 HashMaps) - #52446 (Block beta if clippy breaks.) r? @ghost
☀️ Test successful - status-appveyor, status-travis |
Tested on commit rust-lang/rust@4bff385. Direct link to PR: <rust-lang/rust#52433> 🎉 miri on windows: build-fail → test-pass. 🎉 miri on linux: build-fail → test-pass. 🎉 nomicon on windows: test-fail → test-pass. 🎉 nomicon on linux: test-fail → test-pass.
Successful merges:
r? @ghost