rustdoc: add flag to control the html_root_url of dependencies #51384

QuietMisdreavus · 2018-06-05T23:44:03Z

The --extern-html-root-url flag in this PR allows one to override links to crates whose docs are not already available locally in the doc bundle. Docs.rs currently uses a version of this to make sure links to other crates go into that crate's docs.rs page. See the included test for intended use, but the idea is as follows:

Calling rustdoc with --extern-html-root-url crate=https://some-url.com will cause rustdoc to override links that point to that crate to instead be replaced with a link rooted at https://some-url.com/. (e.g. for docs.rs this would be https://docs.rs/crate/0.1.0 or the like.) Cheekily, rustup could use these options to redirect links to std/core/etc to instead point to locally-downloaded docs, if it so desired.

Fixes #19603

rust-highfive · 2018-06-05T23:44:14Z

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

QuietMisdreavus · 2018-06-05T23:45:27Z

r? @rust-lang/rustdoc

@onur - I modified this slightly from the version you currently use on docs.rs. Mainly, i changed the code to not hard-code docs.rs, by adding the --extern-version-base flag. Does this still work for you?

rust-highfive · 2018-06-06T00:39:06Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/5f/86/363f1249d0b62d7cce3cb8973fb6715b57ca75f8425d6c45fe5e129531a9/awscli-1.15.33-py2.py3-none-any.whl (1.3MB)
    0% |▎                               | 10kB 12.2MB/s eta 0:00:01
    1% |▌                               | 20kB 940kB/s eta 0:00:02
    2% |▉                               | 30kB 1.2MB/s eta 0:00:02
    3% |█                               | 40kB 1.3MB/s eta 0:00:01
---

[00:05:15] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:16] tidy error: /checkout/src/librustdoc/lib.rs:162: line longer than 100 chars
[00:05:17] some tidy checks failed
[00:05:17] 
[00:05:17] 
[00:05:17] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:17] 
[00:05:17] 
[00:05:17] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:17] Build completed unsuccessfully in 0:02:02
[00:05:17] Build completed unsuccessfully in 0:02:02
[00:05:17] make: *** [tidy] Error 1
[00:05:17] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:26302b5e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

ollie27 · 2018-06-06T07:16:54Z

This should probably require passing the full URL like --extern-html-root-url core=https://example.com/core/0.1.0 rather than hard-coding the URL scheme of doc.rs.

I guess this will fix #19603?

QuietMisdreavus · 2018-06-06T13:48:17Z

This should probably require passing the full URL like --extern-html-root-url core=https://example.com/core/0.1.0 rather than hard-coding the URL scheme of doc.rs.

That's probably a better solution. @onur, will this work out on your end?

I guess this will fix #19603?

Looks like it! I forgot there was an issue for this, haha.

onur · 2018-06-09T10:11:28Z

@QuietMisdreavus thank you very much for porting this change. Yes I think @ollie27's solution is better, and it will allow anyone to create his own documentation repository.

I'll test this as soon as I can and return to you.

QuietMisdreavus · 2018-06-12T19:21:46Z

I've force-pushed a version that uses the single --extern-html-root-url flag.

rust-highfive · 2018-06-12T20:05:17Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:33:54]    Compiling aho-corasick v0.6.4
[00:34:01]    Compiling tempdir v0.3.7
[00:34:35]    Compiling minifier v0.0.11
[00:34:37]    Compiling rustdoc v0.0.0 (file:///checkout/src/librustdoc)
[00:34:37] error: expected one of `.`, `;`, `?`, or an operator, found `let`
[00:34:37]     |
[00:34:37] 436 |     }
[00:34:37] 436 |     }
[00:34:37]     |      - expected one of `.`, `;`, `?`, or an operator here
[00:34:37] 437 | 
[00:34:37] 438 |     let test_args = matches.opt_strs("test-args");
[00:34:37]     |     ^^^ unexpected token
[00:34:39] error: unused import: `Path`
[00:34:39]   --> librustdoc/lib.rs:59:17
[00:34:39]    |
[00:34:39]    |
[00:34:39] 59 | use std::path::{Path, PathBuf};
[00:34:39]    |
[00:34:39]    = note: `-D unused-imports` implied by `-D warnings`
[00:34:39] 
[00:34:39] 
[00:34:39] error: unused import: `externalfiles::ExternalHtml`
[00:34:39]    |
[00:34:39]    |
[00:34:39] 64 | use externalfiles::ExternalHtml;
[00:34:39] 
[00:34:39] error: unused import: `build_codegen_options`
[00:34:39]   --> librustdoc/lib.rs:68:47
[00:34:39]    |
[00:34:39]    |
[00:34:39] 68 | use rustc::session::config::{nightly_options, build_codegen_options};
[00:34:39] 
[00:34:48] error[E0308]: mismatched types
[00:34:48]    --> librustdoc/html/render.rs:642:62
[00:34:48]     |
[00:34:48]     |
[00:34:48] 642 |                                           extern_location(e, extern_url, &cx.dst)));
[00:34:48]     |                                                              ^^^^^^^^^^ expected &str, found enum `std::option::Option`
[00:34:48]     = note: expected type `&str`
[00:34:48]     = note: expected type `&str`
[00:34:48]                found type `std::option::Option<&str>`
[00:34:48] error[E0308]: mismatched types
[00:34:48]     --> librustdoc/html/render.rs:1100:12
[00:34:48]      |
[00:34:48]      |
[00:34:48] 1100 |     if let Some(url) = extern_url {
[00:34:48]      |            ^^^^^^^^^ expected str, found enum `std::option::Option`
[00:34:48]      = note: expected type `str`
[00:34:48]                 found type `std::option::Option<_>`
[00:34:48] 
[00:34:52] error: aborting due to 6 previous errors
---
[00:34:52] 
[00:34:52] 
[00:34:52] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:34:52] Build completed unsuccessfully in 0:29:42
[00:34:52] make: *** [all] Error 1
[00:34:52] Makefile:28: recipe for target 'all' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:00af419b
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0da85186:start=1528833911277631734,finish=1528833911285533885,duration=7902151
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:094cecee
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.v

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-12T21:32:33Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:start:test_rustdoc
Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:08:10] 
[01:08:10] running 239 tests
[01:09:34] ....................i...........F...................................................................
[01:10:35] .......................................
[01:10:35] failures:
[01:10:35] 
[01:10:35] 
[01:10:35] ---- [rustdoc] rustdoc/extern-html-root-url.rs stdout ----
[01:10:35] error: rustdoc failed!
[01:10:35] status: exit code: 1
[01:10:35] status: exit code: 1
[01:10:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/extern-html-root-url/auxiliary" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/extern-html-root-url" "/checkout/src/test/rustdoc/extern-html-root-url.rs" "-Z" "unstable-options" "--extern-html-root-url" "https://example.com/core/0.1.0"
[01:10:35] ------------------------------------------
[01:10:35] 
[01:10:35] ------------------------------------------
[01:10:35] stderr:
[01:10:35] stderr:
[01:10:35] ------------------------------------------
[01:10:35] error: --extern-html-root-url must be of the form name=url
[01:10:35] 
[01:10:35] ------------------------------------------
[01:10:35] 
[01:10:35] 
[01:10:35] thread '[rustdoc] rustdoc/extern-html-root-url.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3139:9
[01:10:35] 
[01:10:35] 
[01:10:35] failures:
[01:10:35] failures:
[01:10:35]     [rustdoc] rustdoc/extern-html-root-url.rs
[01:10:35] test result: FAILED. 236 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out
[01:10:35] 
[01:10:35] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[01:10:35] 
[01:10:35] 
[01:10:35] 
[01:10:35] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:10:35] 
[01:10:35] 
[01:10:35] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:10:35] Build completed unsuccessfully in 0:25:36
[01:10:35] Build completed unsuccessfully in 0:25:36
[01:10:35] Makefile:58: recipe for target 'check' failed
[01:10:35] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:12feb459
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:027a6ea6:start=1528839150517306165,finish=1528839150524361772,duration=7055607
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:10ec87be
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09205dc4
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

pietroalbini · 2018-06-18T09:30:15Z

Ping from triage @rust-lang/rustdoc! This PR needs your review.

GuillaumeGomez · 2018-06-18T10:46:27Z

It's up to @onur in here. :)

pietroalbini · 2018-06-18T12:35:44Z

r? @onur

Edit: they're not a member of the org so they can't be assigned to the PR.

GuillaumeGomez · 2018-06-19T07:59:04Z

@onur will just give his approval and at this point I'll r=onur.

pietroalbini · 2018-06-25T11:21:56Z

Ping from triage @onur! This PR needs your review.

stokhos · 2018-06-29T18:57:13Z

Ping from triage @onur will you have time to review this PR?

stokhos · 2018-07-06T19:30:06Z

Ping from triage @rust-lang/rustdoc , guys, this PR needs a new reviewer.

QuietMisdreavus · 2018-07-06T20:14:40Z

We were specifically asking for @onur's expertise, as this feature was written for use within docs.rs.

GuillaumeGomez · 2018-07-06T20:54:13Z

You should ask to @onur to review directly on IRC. :)

stokhos · 2018-07-21T04:31:53Z

Ping from triage @onur will you have time to review this PR?

pietroalbini · 2018-07-30T17:16:40Z

Ping from triage @onur! This PR needs your review.

TimNN · 2018-08-07T17:42:01Z

Ping from triage @rust-lang/rustdoc. It looks like @onur is unresponsive here. Could you please make a decision on how to move forward with this PR? Otherwise I'll close this, given that it has been blocked for over a month now, as per our triage guidelines.

GuillaumeGomez · 2018-08-08T08:16:33Z

This has been done specifically for docs.rs so we really need @onur's review in here. I'll try to reach him on IRC.

pietroalbini · 2018-08-27T15:30:22Z

Ping from triage @onur! This PR needs your review.

GuillaumeGomez · 2018-08-30T19:09:36Z

Time to get it in.

@bors: r+

bors · 2018-08-30T19:09:37Z

📌 Commit fcb54f6 has been approved by GuillaumeGomez

bors · 2018-08-31T05:56:58Z

⌛ Testing commit fcb54f6 with merge 2366eda5a0c0a960fe94ad5afc7a9197bef04852...

bors · 2018-08-31T06:52:11Z

💔 Test failed - status-travis

rust-highfive · 2018-08-31T06:52:13Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:52:20] test [run-make] run-make/thumb-none-cortex-m ... FAILED
[00:52:20] 
[00:52:20] failures:
[00:52:20] 
[00:52:20] ---- [run-make] run-make/thumb-none-cortex-m stdout ----
[00:52:20] error: make failed
[00:52:20] status: exit code: 2
[00:52:20] command: "make"
[00:52:20] stdout:
---
[00:52:20] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[00:52:20] S=/checkout
[00:52:20] _=/bin/sh
[00:52:20] TOOLSTATE_REPO_ACCESS_TOKEN=[secure]
[00:52:20] TRAVIS=true
[00:52:20] RUST_RELEASE_CHANNEL=nightly
[00:52:20] PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[00:52:20] RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
[00:52:20] RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[00:52:20] RUST_BUILD_STAGE=stage2-thumbv6m-none-eabi
[00:52:20] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[00:52:20] SCRIPT=python2.7 ../x.py test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make &&       python2.7 ../x.py dist --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:52:20] AR=ar
[00:52:20] TRAVIS_BRANCH=auto
[00:52:20] RUSTC_BOOTSTRAP=1
[00:52:20] HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:52:20] SCCACHE_BUCKET=rust-lang-ci-sccache2
[00:52:20] PWD=/checkout/obj
[00:52:20] CI_JOB_NAME=dist-various-1
[00:52:20] TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib
[00:52:20] LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
[00:52:20] PYTHON=/usr/bin/python2.7
[00:52:20] HOME=/home/user
[00:52:20] LD_LIBRARY_PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:52:20] HOSTNAME=92c2208b177b
[00:52:20] CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
[00:52:20] SHLVL=2
[00:52:20] CC= 
[00:52:20] BUILD_DIR=/checkout/obj/build
[00:52:20] BUILD_DIR=/checkout/obj/build
[00:52:20] RUST_TEST_TMPDIR=/checkout/obj/build/tmp
[00:52:20] LLVM_CXXFLAGS=
[00:52:20] STAGING_DIR=/tmp
[00:52:20] TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[00:52:20] TARGETS=asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:52:20] RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te       --musl-root-arm=/musl-arm       --musl-root-armhf=/musl-armhf       --musl-root-armv7=/musl-armv7       --musl-root-aarch64=/musl-aarch64       --musl-root-mips=/musl-mips       --musl-root-mipsel=/musl-mipsel       --enable-emscripten       --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-openssl-static --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp
[00:52:20] MAKEFLAGS=
[00:52:20] MFLAGS=
[00:52:20] BOOTSTRAP_PARENT_ID=1045
[00:52:20] BOOTSTRAP_PARENT_ID=1045
[00:52:20] __COMPAT_LAYER=RunAsInvoker
[00:52:20] CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
[00:52:20] BUILD=x86_64-unknown-linux-gnu
[00:52:20] CXX= 
[00:52:20] AWS_ACCESS_KEY_ID=AKIAJAMV3QAMMA6AXHFQ
[00:52:20] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[00:52:20] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[00:52:20] CARGO_HOME=/cargo
[00:52:20] RUSTC_LINKER=arm-none-eabi-gcc
[00:52:20] SCCACHE_REGION=us-west-1
[00:52:20] CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
[00:52:20] LLVM_COMPONENTS=
[00:52:20] TERM=xterm
[00:52:20] MAKELEVEL=1
[00:52:20] mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[00:52:20] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && rm -rf cortex-m
[00:52:20] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && bash -x /checkout/src/test/run-make/thumb-none-cortex-m/../git_clone_sha1.sh cortex-m https://github.com/rust-embedded/cortex-m a448e9156e2cb1e556e5441fd65426952ef4b927 
[00:52:20] Makefile:29: recipe for target 'all' failed
[00:52:20] 
[00:52:20] ------------------------------------------
[00:52:20] stderr:
[00:52:20] stderr:
[00:52:20] ------------------------------------------
[00:52:20] + PROJECT_NAME=cortex-m
[00:52:20] + URL=https://github.com/rust-embedded/cortex-m
[00:52:20] + SHA1=a448e9156e2cb1e556e5441fd65426952ef4b927
[00:52:20] + git clone https://github.com/rust-embedded/cortex-m cortex-m
[00:52:20] Cloning into 'cortex-m'...
[00:52:20] fatal: unable to access 'https://github.com/rust-embedded/cortex-m/': Could not resolve host: github.com
[00:52:20] + err_exit
[00:52:20] + echo ERROR:
[00:52:20] + exit 1
[00:52:20] make: *** [all] Error 1
[00:52:20] ------------------------------------------
[00:52:20] 
[00:52:20] 
[00:52:20] thread '[run-make] run-make/thumb-none-cortex-m' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3196:9
[00:52:20] 
[00:52:20] 
[00:52:20] failures:
[00:52:20]     [run-make] run-make/thumb-none-cortex-m
[00:52:20]     [run-make] run-make/thumb-none-cortex-m
[00:52:20] 
[00:52:20] test result: FAILED. 6 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[00:52:20] 
[00:52:20] 
[00:52:20] 
[00:52:20] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-thumbv6m-none-eabi" "--mode" "run-make" "--target" "thumbv6m-none-eabi" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "arm-none-eabi-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/thumbv6m-none-eabi/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--llvm-version" "7.0.0\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:52:20] 
[00:52:20] 
[00:52:20] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make
[00:52:20] Build completed unsuccessfully in 0:46:32
---
travis_time:end:07682c00:start=1535698267659480133,finish=1535698267667865918,duration=8385785
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1abdf15a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00d30432
travis_time:start:00d30432
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:09cbc3bc
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

QuietMisdreavus · 2018-08-31T13:43:02Z

[00:52:20] Cloning into 'cortex-m'...
[00:52:20] fatal: unable to access 'https://github.com/rust-embedded/cortex-m/': Could not resolve host: github.com

@bors retry

bors · 2018-08-31T17:39:36Z

⌛ Testing commit fcb54f6 with merge aaa170b...

rustdoc: add flag to control the html_root_url of dependencies The `--extern-html-root-url` flag in this PR allows one to override links to crates whose docs are not already available locally in the doc bundle. Docs.rs currently uses a version of this to make sure links to other crates go into that crate's docs.rs page. See the included test for intended use, but the idea is as follows: Calling rustdoc with `--extern-html-root-url crate=https://some-url.com` will cause rustdoc to override links that point to that crate to instead be replaced with a link rooted at `https://some-url.com/`. (e.g. for docs.rs this would be `https://docs.rs/crate/0.1.0` or the like.) Cheekily, rustup could use these options to redirect links to std/core/etc to instead point to locally-downloaded docs, if it so desired. Fixes #19603

bors · 2018-08-31T19:59:50Z

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing aaa170b to master...

rust-highfive assigned frewsxcv Jun 5, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2018

rust-highfive unassigned frewsxcv Jun 5, 2018

QuietMisdreavus force-pushed the extern-version branch from 1596678 to 696e5bd Compare June 12, 2018 19:20

QuietMisdreavus changed the title ~~rustdoc: add --extern-version and --extern-version-base flags~~ rustdoc: add flag to control the html_root_url of dependencies Jun 12, 2018

rustdoc: add --extern-html-root-url flag

db113f5

QuietMisdreavus force-pushed the extern-version branch from 878c8fa to 8c5bf91 Compare June 12, 2018 20:19

add test for --extern-html-root-url

fcb54f6

QuietMisdreavus force-pushed the extern-version branch from 8c5bf91 to fcb54f6 Compare June 12, 2018 21:38

stokhos added the I-nominated label Jul 21, 2018

QuietMisdreavus added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 23, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2018

QuietMisdreavus removed the I-nominated label Aug 31, 2018

bors merged commit fcb54f6 into rust-lang:master Aug 31, 2018

QuietMisdreavus deleted the extern-version branch August 31, 2018 20:30

QuietMisdreavus mentioned this pull request Nov 5, 2018

rustdoc and linking to stdlib docs #35183

Closed

QuietMisdreavus mentioned this pull request Jan 11, 2019

Support relative links between crates? rust-lang/docs.rs#204

Open

anp mentioned this pull request Jul 2, 2020

Link no-deps documentation with no html_root_url to docs.rs by default #42301

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: add flag to control the html_root_url of dependencies #51384

rustdoc: add flag to control the html_root_url of dependencies #51384

QuietMisdreavus commented Jun 5, 2018 •

edited

Loading

rust-highfive commented Jun 5, 2018

QuietMisdreavus commented Jun 5, 2018

rust-highfive commented Jun 6, 2018

ollie27 commented Jun 6, 2018

QuietMisdreavus commented Jun 6, 2018

onur commented Jun 9, 2018

QuietMisdreavus commented Jun 12, 2018

rust-highfive commented Jun 12, 2018

rust-highfive commented Jun 12, 2018

pietroalbini commented Jun 18, 2018

GuillaumeGomez commented Jun 18, 2018

pietroalbini commented Jun 18, 2018 •

edited

Loading

GuillaumeGomez commented Jun 19, 2018

pietroalbini commented Jun 25, 2018

stokhos commented Jun 29, 2018

stokhos commented Jul 6, 2018

QuietMisdreavus commented Jul 6, 2018

GuillaumeGomez commented Jul 6, 2018

stokhos commented Jul 21, 2018

pietroalbini commented Jul 30, 2018

TimNN commented Aug 7, 2018

GuillaumeGomez commented Aug 8, 2018

pietroalbini commented Aug 27, 2018

GuillaumeGomez commented Aug 30, 2018

bors commented Aug 30, 2018

bors commented Aug 31, 2018

bors commented Aug 31, 2018

rust-highfive commented Aug 31, 2018

QuietMisdreavus commented Aug 31, 2018

bors commented Aug 31, 2018

bors commented Aug 31, 2018

rustdoc: add flag to control the html_root_url of dependencies #51384

rustdoc: add flag to control the html_root_url of dependencies #51384

Conversation

QuietMisdreavus commented Jun 5, 2018 • edited Loading

rust-highfive commented Jun 5, 2018

QuietMisdreavus commented Jun 5, 2018

rust-highfive commented Jun 6, 2018

ollie27 commented Jun 6, 2018

QuietMisdreavus commented Jun 6, 2018

onur commented Jun 9, 2018

QuietMisdreavus commented Jun 12, 2018

rust-highfive commented Jun 12, 2018

rust-highfive commented Jun 12, 2018

pietroalbini commented Jun 18, 2018

GuillaumeGomez commented Jun 18, 2018

pietroalbini commented Jun 18, 2018 • edited Loading

GuillaumeGomez commented Jun 19, 2018

pietroalbini commented Jun 25, 2018

stokhos commented Jun 29, 2018

stokhos commented Jul 6, 2018

QuietMisdreavus commented Jul 6, 2018

GuillaumeGomez commented Jul 6, 2018

stokhos commented Jul 21, 2018

pietroalbini commented Jul 30, 2018

TimNN commented Aug 7, 2018

GuillaumeGomez commented Aug 8, 2018

pietroalbini commented Aug 27, 2018

GuillaumeGomez commented Aug 30, 2018

bors commented Aug 30, 2018

bors commented Aug 31, 2018

bors commented Aug 31, 2018

rust-highfive commented Aug 31, 2018

QuietMisdreavus commented Aug 31, 2018

bors commented Aug 31, 2018

bors commented Aug 31, 2018

QuietMisdreavus commented Jun 5, 2018 •

edited

Loading

pietroalbini commented Jun 18, 2018 •

edited

Loading