-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: Fix another double-lint issue with crate::
#50982
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
This commit fixes another issue in the `absolute_path_not_starting_with_crate` lint where it warns twice about an import which may contain `self`. It turns out there were a few more locations that needed updating to use `root_id` and `root_span` introduced in rust-lang#50970 and after that it looks to work like a charm! Closes rust-lang#50978
8ddbcbb
to
e39c959
Compare
@bors r+ p=2 Giving higher priority because Rust 2018 migration is important. |
📌 Commit e39c959 has been approved by |
⌛ Testing commit e39c959 with merge afdb851e1f648123780bf1ac069fac4022616b52... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rustc: Fix another double-lint issue with `crate::` This commit fixes another issue in the `absolute_path_not_starting_with_crate` lint where it warns twice about an import which may contain `self`. It turns out there were a few more locations that needed updating to use `root_id` and `root_span` introduced in #50970 and after that it looks to work like a charm! Closes #50978
☀️ Test successful - status-appveyor, status-travis |
This commit fixes another issue in the
absolute_path_not_starting_with_crate
lint where it warns twice about an import which may contain
self
. It turns outthere were a few more locations that needed updating to use
root_id
androot_span
introduced in #50970 and after that it looks to work like a charm!Closes #50978