-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not silently truncate offsets for read_at
/write_at
on emscripten
#50634
Conversation
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup |
📌 Commit d71625b has been approved by |
…nnytm Do not silently truncate offsets for `read_at`/`write_at` on emscripten Generate an IO error if the offset is out of bounds for the system call.
@bors: r- This caused a rollup failure. I've attempted to fix it in the rollup so it's not necessary to update this PR if the rollup lands. Also a friendly reminder to please test PRs, it looks like this was not tested on the target platform of the PR before being submitted. |
Oops, missing import.
|
I've decided to close the rollup, so this PR will need to be fixed |
(please be sure to test it to make sure the import suggestions work) |
Generate an IO error if the offset is out of bounds for the system call.
d71625b
to
4ce2426
Compare
Where do I find documentation for building the standard library for emscripten? |
@tbu- First, you enable [rust]
codegen-backends = ["llvm", "emscripten"] then, to build, you run ./x.py build --stage 1 src/libstd --target asmjs-unknown-emscripten However, I believe you could quickly check for syntax error just using ./x.py check src/libstd --target asmjs-unknown-emscripten |
Re |
Oh nvm, now it has. EDIT: Thanks for the instructions on how to build! |
@bors r+ |
📌 Commit 4ce2426 has been approved by |
…nnytm Do not silently truncate offsets for `read_at`/`write_at` on emscripten Generate an IO error if the offset is out of bounds for the system call.
Rollup of 13 pull requests Successful merges: - #50544 (Cleanup some dependencies) - #50545 (Made some functions in time module const) - #50550 (use fmt::Result where applicable) - #50558 (Remove all reference to DepGraph::work_products) - #50602 (Update canonicalize docs) - #50607 (Allocate Symbol strings from an arena) - #50613 (Migrate the toolstate update bot to rust-highfive) - #50624 (fs::write: Add example writing a &str) - #50634 (Do not silently truncate offsets for `read_at`/`write_at` on emscripten) - #50644 (AppVeyor: Read back trace from crash dump on failure.) - #50661 (Ignore non .rs files for tidy libcoretest) - #50663 (rustc: Allow an edition's feature on that edition) - #50667 (rustc: Only suggest deleting `extern crate` if it works) Failed merges:
…nnytm Do not silently truncate offsets for `read_at`/`write_at` on emscripten Generate an IO error if the offset is out of bounds for the system call.
Rollup of 8 pull requests Successful merges: - #50624 (fs::write: Add example writing a &str) - #50634 (Do not silently truncate offsets for `read_at`/`write_at` on emscripten) - #50644 (AppVeyor: Read back trace from crash dump on failure.) - #50661 (Ignore non .rs files for tidy libcoretest) - #50663 (rustc: Allow an edition's feature on that edition) - #50667 (rustc: Only suggest deleting `extern crate` if it works) - #50670 (rustc: Include semicolon when removing `extern crate`) - #50678 (Update openbsd targets) Failed merges:
Generate an IO error if the offset is out of bounds for the system call.