Add error message for using >= 65535 hashes for raw string literal escapes #50296

dcao · 2018-04-28T06:06:24Z

kennytm · 2018-04-28T06:16:39Z

kennytm · 2018-04-28T06:19:08Z

src/test/ui/raw_string_hash_count.rs

+// except according to those terms.
+
+fn main() {
+    let x = r################################################################################################################################################################################################################################################################"test"################################################################################################################################################################################################################################################################


This file needs an // ignore-tidy-linelength header.

varkor

It's looking good to me! I just left a few very minor comments.

The test is currently failing because the offset in the line/column number is wrong (after you added the line to ignore tidy), but once you tweak the range/text you can just regenerate it.

varkor · 2018-04-28T09:59:45Z

src/test/ui/raw_string_hash_count.stderr

+error: too many `#` characters surrounding a raw string; only 255 or fewer characters can be used
+  --> src/test/ui/raw_string_hash_count.rs:12:13
+   |
+LL |     let x = r################################################################################################################################################################################################################################################################"test"################################################################################################################################################################################################################################################################


Is it possible to offset the range by 1, so that it underlines all the # on the left hand side (i.e. at the moment, the r is included, but not the final #).

varkor · 2018-04-28T10:00:54Z

src/test/ui/raw_string_hash_count.rs

+// ignore-tidy-linelength
+
+fn main() {
+    let x = r################################################################################################################################################################################################################################################################"test"################################################################################################################################################################################################################################################################


For simplicity, you can eliminate the variable as well, and just have the raw string as a standalone statement.

varkor · 2018-04-28T10:02:34Z

src/libsyntax/parse/lexer/mod.rs

+                let last_bpos = self.pos;
+                self.fatal_span_(start_bpos,
+                                    last_bpos,
+                                    "too many `#` characters surrounding a raw string; \


Maybe clarify to "raw byte string". It's probably fine to only test one of them, though, as it's a minor error. Also, the indentation here is off.

varkor · 2018-04-28T10:05:46Z

src/libsyntax/parse/lexer/mod.rs

+                        let last_bpos = self.pos;
+                        self.fatal_span_(start_bpos,
+                                         last_bpos,
+                                         "too many `#` characters surrounding a raw string; \


The wording could be a little more concise here. Maybe:

too many `#` symbols: raw strings may be delimited by up to 255 `#` symbols

(and same for byte strings).

varkor · 2018-04-29T21:34:17Z

src/test/ui/raw_string_hash_count.stderr

@@ -0,0 +1,8 @@
+error: too many `#` symbols: raw strings may be delimited by up to 255 `#` symbols
+  --> src/test/ui/raw_string_hash_count.rs:14:5


You need to replace src/test/ui with $DIR.

rust-highfive · 2018-04-30T07:03:50Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:44:42] ....................................................................................................
[00:44:49] ....................................................................................................
[00:44:55] ....................................................................................................
[00:45:03] ....................................i...............................................................
[00:45:09] ............i.........................................F.............................................
[00:45:23] ....................................................................................................
[00:45:30] ...........i....................................................................
[00:45:30] failures:
[00:45:30] 
[00:45:30] 
[00:45:30] ---- [ui] ui/raw_string_hash_count.rs stdout ----
[00:45:30]  
[00:45:30] error: /checkout/src/test/ui/raw_string_hash_count.rs:14: unexpected error: '14:5: 14:262: too many `#` symbols: raw strings may be delimited by up to 255 `#` symbols'
[00:45:30] 
[00:45:30] error: /checkout/src/test/ui/raw_string_hash_count.rs:14: expected error not found: too many `#` characters
[00:45:30] 
[00:45:30] error: 1 unexpected errors found, 1 expected errors not found
[00:45:30] status: exit code: 101
[00:45:30] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/raw_string_hash_count.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/raw_string_hash_count.stage2-x86_64-unknown-linux-gnu" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/raw_string_hash_count.stage2-x86_64-unknown-linux-gnu.aux" "-A" "unused"
[00:45:30] unexpected errors (from JSON output): [
[00:45:30]     Error {
[00:45:30]         line_num: 14,
[00:45:30]         kind: Some(
[00:45:30]             Error
[00:45:30]         ),
[00:45:30]         msg: "14:5: 14:262: too many `#` symbols: raw strings may be delimited by up to 255 `#` symbols"
[00:45:30] ]
[00:45:30] 
[00:45:30] not found errors (from test file): [
[00:45:30]     Error {
[00:45:30]     Error {
[00:45:30]         line_num: 14,
[00:45:30]         kind: Some(
[00:45:30]             Error
[00:45:30]         ),
[00:45:30]         msg: "too many `#` characters"
[00:45:30] ]
[00:45:30] 
[00:45:30] thread '[ui] ui/raw_string_hash_count.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:1278:13
[00:45:30] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[00:45:30] 
[00:45:30] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:488:22
[00:45:30] 
[00:45:30] 
[00:45:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:45:30] 
[00:45:30] 
[00:45:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:45:30] Build completed unsuccessfully in 0:02:45
[00:45:30] Build completed unsuccessfully in 0:02:45
[00:45:30] Makefile:58: recipe for target 'check' failed
[00:45:30] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:044c0ffa
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

varkor · 2018-04-30T09:37:44Z

src/test/ui/raw_string_hash_count.rs

+
+fn main() {
+    r################################################################################################################################################################################################################################################################"test"################################################################################################################################################################################################################################################################;
+    //~^ ERROR too many `#` characters


This needs to be updated to use symbols instead of characters.

eddyb · 2018-04-30T13:24:33Z

Why do we want to do this? cc @rust-lang/compiler

nagisa · 2018-04-30T13:41:26Z

Probably for better diagnostics? We either introduce some limit or make the number of hashes technically unlimited by counting them into u64 or larger.

oli-obk · 2018-04-30T15:19:39Z

Idk. Doesn't feel like something that we are allowed to break under the breaking change rules. Then again, seems like an accident that such riddiculous numbers of hashes are allowed.

nikomatsakis · 2018-04-30T17:12:33Z

I feel ok about going to u8 for now if it'll help with perf. Searching through crates.io with a simple regex, it seems pretty clear that this will not break anything.

eddyb · 2018-04-30T17:15:06Z

@nikomatsakis I don't thinks this helps anything. @nnethercote changed it to u16 for a size win, but going to u8 doesn't reduce that size any further.

nikomatsakis · 2018-04-30T17:21:05Z

OK, point is, we can impose a limit. I'm indifferent about what limit we impose.

estebank · 2018-05-01T03:40:18Z

@CMDD could you squash your commits?

dcao · 2018-05-01T05:21:04Z

@estebank commits have been squashed, hopefully without messing anything up in the process

eddyb · 2018-05-01T06:45:56Z

I'm nominating this PR for discussion, on the topic of what limits can an implementation reasonably have (rustc currently uses u32 in a bunch of places where usize would be impossible to overflow).

joshtriplett · 2018-05-10T19:33:50Z

We discussed this in the lang team meeting, and we all agreed that we can safely limit this to 255 without concern.

nikomatsakis · 2018-06-08T15:02:04Z

@CMDD merge conflict :(

pietroalbini · 2018-06-08T16:10:41Z

@CMDD you should rebase on master, even if you don't see any conflict at first glance.

… strings

dcao · 2018-06-08T22:42:44Z

Sorry for the delay! I've rebased onto master.

dcao · 2018-06-13T05:24:29Z

@nikomatsakis Are these changes good to be pushed onto rust-lang/master?

nikomatsakis · 2018-06-15T13:50:23Z

@bors r+

bors · 2018-06-15T13:50:24Z

📌 Commit 313d6c5 has been approved by nikomatsakis

bors · 2018-06-15T13:50:36Z

⌛ Testing commit 313d6c5 with merge ab0a442...

Add error message for using >= 65535 hashes for raw string literal escapes Fixes #50111.

bors · 2018-06-15T14:59:25Z

💔 Test failed - status-appveyor

pietroalbini · 2018-06-15T15:02:15Z

@bors retry #51565

bors · 2018-06-15T16:07:14Z

⌛ Testing commit 313d6c5 with merge 2bd50a523053b5bd02014a73e45a072663efcb53...

pietroalbini · 2018-06-15T16:38:03Z

Give priority to #51565, which should fix the failure.

@bors retry

bors · 2018-06-15T19:05:31Z

⌛ Testing commit 313d6c5 with merge 967c1f3...

Add error message for using >= 65535 hashes for raw string literal escapes Fixes #50111.

bors · 2018-06-15T21:13:33Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 967c1f3 to master...

kennytm added T-lang Relevant to the language team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2018

rust-highfive assigned eddyb Apr 28, 2018

This comment has been minimized.

Sign in to view

kennytm reviewed Apr 28, 2018

View reviewed changes

This comment has been minimized.

Sign in to view

varkor suggested changes Apr 28, 2018

View reviewed changes

This comment has been minimized.

Sign in to view

varkor reviewed Apr 29, 2018

View reviewed changes

varkor reviewed Apr 30, 2018

View reviewed changes

dcao force-pushed the master branch from 9c19f19 to 6be67ce Compare May 1, 2018 05:18

eddyb added the I-nominated label May 1, 2018

shepmaster added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2018

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed I-nominated S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels May 10, 2018

nikomatsakis approved these changes Jun 8, 2018

View reviewed changes

provide error message when using more than 65535 hash symbols for raw…

313d6c5

… strings

dcao force-pushed the master branch from 5a6b36a to 313d6c5 Compare June 8, 2018 22:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2018

bors added a commit that referenced this pull request Jun 15, 2018

Auto merge of #50296 - cmdd:master, r=nikomatsakis

ab0a442

Add error message for using >= 65535 hashes for raw string literal escapes Fixes #50111.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 15, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2018

bors added a commit that referenced this pull request Jun 15, 2018

Auto merge of #50296 - cmdd:master, r=nikomatsakis

967c1f3

Add error message for using >= 65535 hashes for raw string literal escapes Fixes #50111.

bors merged commit 313d6c5 into rust-lang:master Jun 15, 2018

petrochenkov mentioned this pull request Jun 1, 2020

RawString error reporting cleanup #72884

Merged

Julian-Wollersberger mentioned this pull request Oct 7, 2020

Cleanup of eat_while() in lexer #77629

Merged

scottmcm mentioned this pull request Mar 28, 2022

Reduce max hash in raw strings from u16 to u8 #95251

Merged

pnkfelix mentioned this pull request May 16, 2022

Upper bound on hashes in raw string literals rust-lang/reference#1180

Merged

		@@ -0,0 +1,8 @@
		error: too many `#` symbols: raw strings may be delimited by up to 255 `#` symbols
		--> src/test/ui/raw_string_hash_count.rs:14:5

Add error message for using >= 65535 hashes for raw string literal escapes #50296

Add error message for using >= 65535 hashes for raw string literal escapes #50296

Conversation

dcao commented Apr 28, 2018

kennytm commented Apr 28, 2018

This comment has been minimized.

kennytm Apr 28, 2018

Choose a reason for hiding this comment

This comment has been minimized.

varkor left a comment

Choose a reason for hiding this comment

varkor Apr 28, 2018

Choose a reason for hiding this comment

varkor Apr 28, 2018

Choose a reason for hiding this comment

varkor Apr 28, 2018

Choose a reason for hiding this comment

varkor Apr 28, 2018

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

varkor Apr 29, 2018

Choose a reason for hiding this comment

rust-highfive commented Apr 30, 2018

varkor Apr 30, 2018

Choose a reason for hiding this comment

eddyb commented Apr 30, 2018

nagisa commented Apr 30, 2018

oli-obk commented Apr 30, 2018

nikomatsakis commented Apr 30, 2018 • edited Loading

eddyb commented Apr 30, 2018

nikomatsakis commented Apr 30, 2018

estebank commented May 1, 2018

dcao commented May 1, 2018

eddyb commented May 1, 2018

joshtriplett commented May 10, 2018

nikomatsakis commented Jun 8, 2018

pietroalbini commented Jun 8, 2018

dcao commented Jun 8, 2018

dcao commented Jun 13, 2018

nikomatsakis commented Jun 15, 2018

bors commented Jun 15, 2018

bors commented Jun 15, 2018

bors commented Jun 15, 2018

pietroalbini commented Jun 15, 2018

bors commented Jun 15, 2018

pietroalbini commented Jun 15, 2018

bors commented Jun 15, 2018

bors commented Jun 15, 2018

nikomatsakis commented Apr 30, 2018 •

edited

Loading