Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop elaboration should reveal all #50253

Merged
merged 3 commits into from
Apr 27, 2018
Merged

drop elaboration should reveal all #50253

merged 3 commits into from
Apr 27, 2018

Conversation

nikomatsakis
Copy link
Contributor

This used to happen implicitly through the normalization function; but we now keep the param-env as is, which seems less surprising.

cc #49685

r? @eddyb

@nikomatsakis
improved debug output
2a58875
@nikomatsakis
use reveal_all during drop elaboration
0361e59 
This used to happen by default as part of the normalization routine
that was being used.
@nikomatsakis
add regression test
86e9a7a 
Fixes rust-lang#49685
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2018
@eddyb
Copy link
Member

eddyb commented Apr 26, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2018

📌 Commit 86e9a7a has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2018
@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 26, 2018
@pietroalbini
Copy link
Member

@bors p=1

Fixes beta regression.

@bors
Copy link
Contributor

bors commented Apr 26, 2018

⌛ Testing commit 86e9a7a with merge 7d8f0e2...

bors added a commit that referenced this pull request Apr 26, 2018
@bors
Auto merge of #50253 - nikomatsakis:regressions-2018-04-26, r=eddyb
7d8f0e2 
drop elaboration should reveal all

This used to happen implicitly through the normalization function; but we now keep the param-env as is, which seems less surprising.

cc #49685

r? @eddyb
@bors
Copy link
Contributor

bors commented Apr 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 7d8f0e2 to master...

@bors bors merged commit 86e9a7a into rust-lang:master Apr 27, 2018
@pietroalbini pietroalbini mentioned this pull request Apr 27, 2018
Merged
@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 27, 2018
bors added a commit that referenced this pull request Apr 27, 2018
@bors
Auto merge of #50274 - pietroalbini:beta-backports, r=alexcrichton
6eef61a 
[beta] More backports

* #49368: Feature gate where clauses on associated types
* #50253: drop elaboration should reveal all *(needs `beta-accepted` stamp)*

r? @alexcrichton
This was referenced Apr 16, 2019
Closed
Closed
@lqd lqd mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikomatsakis @eddyb @bors @pietroalbini @alexcrichton @rust-highfive