Remove hack around comparisons of i1 values (fixes #40980)

[nox]

The regression test still passes without that 2 years old hack. The underlying
LLVM bug has probably been fixed upstream since then.

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[nox]

r? @eddyb

[jonas-schievink]

#36856 is already closed, did you mean to link #40980 instead?

[nox]

Oh yes.

[hanna-kruppe]

As discussed in #40980, we still support LLVM 3.9 which does not have the bug fix. There are other miscompilations where we have backported fixes but don't work around them on old LLVM versions (passing responsibility to backport to people who build with old LLVM versions), but this is still sort of a big step.

[hanna-kruppe]

Nevermind, it turns out LLVM 3.9 never had this bug to begin with, it only ever existed in https://github.com/rust-lang/llvm/ (and doesn't any more in current versions).

[eddyb]

@bors r+

[bors]

📌 Commit 5d5fb97 has been approved by eddyb

[bors]

⌛ Testing commit 5d5fb97 with merge 50002ae7707fae917ed7430e2037e05de19c5ff0...

[bors]

💔 Test failed - status-appveyor

[rust-highfive]

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:01:25]  Downloading serde_derive v1.0.40
[00:01:25] error: unable to get packages from source
[00:01:25] 
[00:01:25] Caused by:
[00:01:25]   failed to get 200 response from `https://crates.io/api/v1/crates/serde_derive/1.0.40/download`, got 404
[00:01:25] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:25] Build completed unsuccessfully in 0:00:37
[00:01:25] Makefile:81: recipe for target 'prepare' failed
[00:01:25] make: *** [prepare] Error 1
[00:01:25]  Downloading cc v1.0.10
[00:01:25] error: unable to get packages from source
[00:01:25] 
[00:01:25] Caused by:
[00:01:25] Caused by:
[00:01:25]   failed to get 200 response from `https://crates.io/api/v1/crates/cc/1.0.10/download`, got 404
[00:01:25] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:25] Build completed unsuccessfully in 0:00:00
[00:01:26] Makefile:81: recipe for target 'prepare' failed
[00:01:26] make: *** [prepare] Error 1
[00:01:26]  Downloading toml v0.4.6
[00:01:26] error: unable to get packages from source
[00:01:26] 
[00:01:26] Caused by:
[00:01:26] Caused by:
[00:01:26]   failed to get 200 response from `https://crates.io/api/v1/crates/toml/0.4.6/download`, got 404
[00:01:26] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:26] Build completed unsuccessfully in 0:00:00
[00:01:26] Makefile:81: recipe for target 'prepare' failed
[00:01:26] make: *** [prepare] Error 1
[00:01:27]  Downloading toml v0.4.6
[00:01:27] error: unable to get packages from source
[00:01:27] 
[00:01:27] Caused by:
[00:01:27] Caused by:
[00:01:27]   failed to get 200 response from `https://crates.io/api/v1/crates/toml/0.4.6/download`, got 404
[00:01:27] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:27] Build completed unsuccessfully in 0:00:00
[00:01:27] Makefile:81: recipe for target 'prepare' failed
[00:01:27] make: *** [prepare] Error 1
[00:01:27]  Downloading serde_derive v1.0.40
[00:01:27] error: unable to get packages from source
[00:01:27] 
[00:01:27] Caused by:
[00:01:27] Caused by:
[00:01:27]   failed to get 200 response from `https://crates.io/api/v1/crates/serde_derive/1.0.40/download`, got 404
[00:01:27] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:27] Build completed unsuccessfully in 0:00:00
[00:01:27] Makefile:81: recipe for target 'prepare' failed
[00:01:27] make: *** [prepare] Error 1
[00:01:27] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:06a943fd
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[nagbot-rs]

@bors: retry * crates.io was down

…

On Tue, Apr 24, 2018 at 8:03 PM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.7134> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#50137 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AaPN0Oc89u94FXoalicwVbtNUhQpmt1Yks5tr8tggaJpZM4TeYpE> . -- You received this message because you are subscribed to the Google Groups "rust-ops" group. To unsubscribe from this group and stop receiving emails from it, send an email to ***@***.*** To post to this group, send email to ***@***.*** To view this discussion on the web visit https://groups.google.com/d/ msgid/rust-ops/rust-lang/rust/pull/50137/c384127160%40github.com <https://groups.google.com/d/msgid/rust-ops/rust-lang/rust/pull/50137/c384127160%40github.com?utm_medium=email&utm_source=footer> . For more options, visit https://groups.google.com/d/optout.

[bors]

@nagbot-rs: 🔑 Insufficient privileges: not in try users

[aturon]

@bors: retry

[bors]

⌛ Testing commit 5d5fb97 with merge a997525...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing a997525 to master...