Update RELEASES.md for 1.26.0 #49523

XAMPPRocky · 2018-03-30T17:37:28Z

Rendered

r? @Mark-Simulacrum

mark-i-m · 2018-03-30T22:16:18Z

Holy moly

mark-i-m · 2018-03-30T22:17:26Z

The links at the end are not supposed to be rendered, right?

kennytm · 2018-03-30T23:32:44Z

RELEASES.md

+- [128-bit integers in the form of `u128` & `i128` are now stable.][49101]
+- [`main` now accepts any type implementing the unstable trait
+  `Termination` (currently `()`, `!`,
+  `Result<(), E: Debug>`, `Result<!, E: Debug>`).][49162]


Maybe don't mention the trait, and just write

main() can now return !, Result<(), E: Debug> and Result<!, E: Debug> in additional to ().

?

kennytm · 2018-03-30T23:33:33Z

RELEASES.md

+- [Stabilised the `!` type (A type that has no value).][47630]
+- [The inclusive range syntax e.g. `for x in 0..=10` is now stable.][47813]
+- [`impl Trait` is now stable allowing you to have abstract
+  return types.][49255] e.g. `fn foo() -> impl Iterator<Item=u8>`


impl Trait can also appear in argument position e.g. fn open(a: impl AsRef<Path>).

kennytm · 2018-03-30T23:33:59Z

RELEASES.md

+
+Compiler
+--------
+- [LLD is now used as the default linker for `wasm32-unknown-target`.][48125]


wasm32-unknown-unknown.

est31 · 2018-03-30T23:40:30Z

RELEASES.md

+Language
+--------
+- [Closures now implement `Copy + Clone` if all captured variables do.][49299]
+- [Stabilised the `!` type (A type that has no value).][47630]


A type that has no value

! isn't just a ZST (zero sized type), it has special powers. Can't recall what exactly they were but a better name would be "never type".

Oh BTW, if we can't find a suitable fix for #49039 (comment), we may be forced to unstabilize ! again.

I think there was a thread where it was decided that "never type" is the official, technically correct pronunciation of "! type", though unfortunately I can't find it. Since ! is how you spell it in code, I'd show both names: "Stabilised the ! type, also known as the "never" type".

"never" is what you need to search for to find it in the docs (https://doc.rust-lang.org/nightly/std/?search=never), so it would be good to include that name here.

Can't recall what exactly they were but a better name would be "never type".

Because there is no value of this type, if the compiler ever sees something with this type, it must be dead code and can be optimized out.

struct Foo; is definitely a ZST: https://doc.rust-lang.org/nomicon/exotic-sizes.html#zero-sized-types-zsts

(enum Void {} can be considered as having "size -∞" that just gets saturated to zero since the API returns usize.)

To clarify: () and struct Foo; are Zero sized types: they have exactly one possible value (() and Foo, respectively), so they can be represented with log(1) = 0 bits, hence the name. ! is not zero-sized; it cannot be represented with any number of bits because there are no values of that type.

I'd say a ZST is any type T that fulfills std::mem::size_of::<T>() == 0. And ! does fulfill it so it is zero sized. I mean when ! has a size of zero, it must be zero-sized right?

In the "abstract" type check world, both struct Foo; and enum Var{} can have values. After all you can do things like let v: ! = panic!(); let w: u32 = v; println!("{}", w + 1);.

In the "technical" code gen world, both () and ! get optimized out, their "values" never get onto the stack. The difference only shows if stuff is nested in stuff like Result, but the nomicon claims that this optimisation is not yet being performed... might be outdated given eddyb's work on it.

So I believe that the statement "a type that has no value" is neither unique to the ! type (as there are types like enum Var {}) nor is 100% accurate as as far as type checking is concerned it actually can.

And ! does fulfill it so it is zero sized.

Do you mean theoretically or in implementation? Theoretically, it should not have size zero; it's size is undefined. I don't know what the implementation of mem::size_of::<!>() does, though. I guess 0 is probably the most reasonable answer, but really None or panic! would be more correct...

@est31 There are expressions of uninhabited types (what you mean by "the type checking perspective"), but none of these expressions ever actually evaluate to a value (if they do via unsafe code, that's UB). So "no values" is an accurate if not unique description of !.

Though the specific phrasing "a type that has no value" has an unfortunate double meaning ("has no value" as in "is useless")...

kennytm · 2018-04-02T09:19:01Z

We need to add fs::{read, write} #49422/#49521, fs::read_to_string() #49522 and process::id() #49574 assuming we still haven't branched beta yet.

tmccombs · 2018-04-02T17:00:27Z

and process::id()

I set the "since" to 1.27 for process::id() because I though beta had been branched. If it hasn't I can make another PR to set it to 1.26.

kennytm · 2018-04-02T18:05:19Z

The branch point of 1.26 has just been set by #49589 to 097efa9. This contains process::id(). So yes @tmccombs we need another PR to change it back to 1.26. Remind us to backport that to beta as well.

mbrubeck · 2018-04-02T21:02:44Z

RELEASES.md

+- [Added hexadecimal formatting for integers with fmt::Debug][48978]
+  e.g. `assert!(format!("{:02x?}", b"Foo\0") == "[46, 6f, 6f, 00]")`
+- [Implemented `Default, Hash` for `cmp::Reverse`.][48628]
+- [Optimized `str::repeat` being 8x fast in large cases.][48657]


typo: "fast" should be "faster"

It was stabilized right before the beta branch was cut for 1.26.0. See rust-lang#49523 (comment)

Fix "since" version for getpid feature. It was stabilized right before the beta branch was cut for 1.26.0. See rust-lang#49523 (comment) This will need to be backported to beta (1.26.0)

mbrubeck · 2018-04-03T18:58:38Z

RELEASES.md

+  `fn open(path: impl AsRef<Path>)`.
+- [Pattern matching on references are now automatically dereferenced.][49394]
+- [128-bit integers in the form of `u128` & `i128` are now stable.][49101]
+- [`main` now accepts any type implementing the unstable trait


Instead of "now accepts any type" I might say "can now return any type"

kennytm · 2018-04-03T19:26:18Z

RELEASES.md

-  `Termination` (currently `()`, `!`,
-  `Result<(), E: Debug>`, `Result<!, E: Debug>`).][49162]
+- [`main` can now return `!`, `Result<(), E: Debug>`,
+  `Result<!, E: Debug>`).][49162] In addition to `()`.


Unnecessary )..

steveklabnik · 2018-04-03T19:35:53Z

RELEASES.md

+      _ => println!("Not all points were sequential."),
+  }
+  ```
+- [Parentheses are now allowed in `dyn` traits.][48481]


dyn Trait isn't stable yet, so should this go in the notes?

I was wondering that myself but it was tagged with relnotes so I left it in.

@Aaronepower @steveklabnik The relnote was about a breaking change like this:

use std::ops::Fn as dyn; fn g(_: Box<dyn(std::fmt::Debug)>) {}

Previously it compiles. Now it causes the E0658 "dyn Trait syntax is unstable" error.

Fix "since" version for getpid feature. It was stabilized right before the beta branch was cut for 1.26.0. See rust-lang#49523 (comment) This will need to be backported to beta (1.26.0)

kennytm · 2018-04-04T10:03:31Z

Please also add #49458 ('_) and #49243 (String::retain) 😂

Given the large amount of stabilization and 1.26-beta being one-week-late, I suggest we double-check c83fa5d...097efa9 for any missing items.

It was stabilized right before the beta branch was cut for 1.26.0. See rust-lang#49523 (comment)

tspiteri · 2018-04-12T10:48:05Z

RELEASES.md

+
+Language
+--------
+- [Closures now implement `Copy + Clone` if all captured variables do.][49299]


I read this as meaning that both Copy and Clone have to be implemented, thus Copy + Clone, but I think this change is also effective if the captured variables are only Clone.

tspiteri · 2018-04-12T10:52:32Z

RELEASES.md

+  return types.][49255] e.g. `fn foo() -> impl Iterator<Item=u8>` or
+  `fn open(path: impl AsRef<Path>)`.
+- [Pattern matching on references are now automatically dereferenced.][49394]
+- [128-bit integers in the form of `u128` & `i128` are now stable.][49101]


I think “u128 and i128” is better than “u128 & i128”, both from a grammar (English not Rust) point of view and because the ampersand can be confused with the & operator at first glance.

mark-i-m · 2018-04-21T03:59:44Z

RELEASES.md

+Language
+--------
+- [Closures now implement `Copy + Clone` if all captured variables do.][49299]
+- [Stabilised the `!` type.][47630] (Also known as the never type).


This is not going to be in 1.26 😢

mark-i-m · 2018-04-21T03:59:58Z

RELEASES.md

+  `fn open(path: impl AsRef<Path>)`.
+- [Pattern matching on references are now automatically dereferenced.][49394]
+- [128-bit integers in the form of `u128` & `i128` are now stable.][49101]
+- [`main` can now return `!`, `Result<(), E: Debug>`,


! should be removed from here.

XAMPPRocky · 2018-05-01T12:50:55Z

@Mark-Simulacrum Done

ollie27

#46882 definitely needs to be mentioned. It stabilised a few things like const indexing.

ollie27 · 2018-05-01T12:53:59Z

RELEASES.md

+- [`Option::cloned`]
+- [`btree_map::Entry::and_modify`]
+- [`convert::TryFrom`]
+- [`convert::TryInto`]


TryFrom and TryInto were destabilised by #50121.

ollie27 · 2018-05-01T12:54:27Z

RELEASES.md

+      let _reversed_pair: &'static _ = &(PAIR.1, PAIR.0); // Doesn't work
+  }
+  ```
+- [Removed the deprecated unstable `SipHasher{13,24}` from documentation.][49108]


SipHasher{13,24} were never stable so there's no reason to include this change.

ollie27 · 2018-05-03T11:36:29Z

RELEASES.md

+- [Implemented `Default, Hash` for `cmp::Reverse`.][48628]
+- [Optimized `str::repeat` being 8x faster in large cases.][48657]
+- [`ascii::escape_default` is now available in libcore.][48735]
+- [Implemented `FromStr` for `PathBuf`][48292]


This is being reverted: #50401.

XAMPPRocky · 2018-05-04T18:59:14Z

@ollie27 What in #46882 do you think specifically needs to be mentioned to users of Rust? There's a lot there.

ollie27 · 2018-05-06T00:06:57Z

What in #46882 do you think specifically needs to be mentioned to users of Rust? There's a lot there.

It's a few small things like being able to use indexing, dereferencing and tuple struct constructors in a const context.

Mark-Simulacrum · 2018-05-07T15:38:23Z

Okay, let's get this landed.

@bors r+

I'm going to say we're probably not going to backport to beta at this point.

bors · 2018-05-07T15:38:24Z

📌 Commit 85f3ecf has been approved by Mark-Simulacrum

kennytm · 2018-05-09T09:19:43Z

@Aaronepower Could you incorporate comments from https://internals.rust-lang.org/t/1-26-0-prerelease-testing/7475/2 (a clarification on impl Trait) and #50555 (a compatibility note)?

kennytm · 2018-05-09T10:18:51Z

@bors r=Mark-Simulacrum

bors · 2018-05-09T10:18:51Z

📌 Commit 111786d has been approved by Mark-Simulacrum

Update RELEASES.md for 1.26.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

Rollup of 11 pull requests Successful merges: - #49988 (Mention Result<!, E> in never docs.) - #50148 (turn `ManuallyDrop::new` into a constant function) - #50456 (Update the Cargo submodule) - #50460 (Make `String::new()` const) - #50464 (Remove some transmutes) - #50505 (Added regression function match value test) - #50511 (Add some explanations for #[must_use]) - #50525 (Optimize string handling in lit_token().) - #50527 (Cleanup a `use` in a raw_vec test) - #50539 (Add more logarithm constants) - #49523 (Update RELEASES.md for 1.26.0) Failed merges:

XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Mar 30, 2018

rust-highfive assigned Mark-Simulacrum Mar 30, 2018

shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2018

kennytm reviewed Mar 30, 2018

View reviewed changes

est31 reviewed Mar 30, 2018

View reviewed changes

est31 approved these changes Apr 2, 2018

View reviewed changes

mbrubeck reviewed Apr 2, 2018

View reviewed changes

tmccombs added a commit to tmccombs/rust that referenced this pull request Apr 3, 2018

Fix "since" version for getpid feature.

9ab5788

It was stabilized right before the beta branch was cut for 1.26.0. See rust-lang#49523 (comment)

tmccombs mentioned this pull request Apr 3, 2018

Fix "since" version for getpid feature. #49612

Merged

mbrubeck reviewed Apr 3, 2018

View reviewed changes

kennytm reviewed Apr 3, 2018

View reviewed changes

steveklabnik reviewed Apr 3, 2018

View reviewed changes

kennytm pushed a commit to matklad/rust that referenced this pull request Apr 5, 2018

Fix "since" version for getpid feature.

4d63e4a

It was stabilized right before the beta branch was cut for 1.26.0. See rust-lang#49523 (comment)

pietroalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2018

tspiteri reviewed Apr 12, 2018

View reviewed changes

pietroalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2018

mark-i-m reviewed Apr 21, 2018

View reviewed changes

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 1, 2018

XAMPPRocky force-pushed the master branch from 7e2de5b to 99ec5e5 Compare May 1, 2018 12:41

Updated RELEASES.md for 1.26.0

4b444f5

XAMPPRocky force-pushed the master branch from 99ec5e5 to 4b444f5 Compare May 1, 2018 12:50

ollie27 reviewed May 1, 2018

View reviewed changes

ollie27 reviewed May 3, 2018

View reviewed changes

Update RELEASES.md

85f3ecf

XAMPPRocky added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2018

kennytm mentioned this pull request May 8, 2018

Rollup of 11 pull requests #50546

Merged

ExpHP mentioned this pull request May 9, 2018

Rejecting higher-kinded lifetime bounds is a breaking change #50555

Closed

Update RELEASES.md

111786d

kennytm added a commit to kennytm/rust that referenced this pull request May 9, 2018

Rollup merge of rust-lang#49523 - Aaronepower:master, r=Mark-Simulacrum

99cd9a9

Update RELEASES.md for 1.26.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

bors merged commit 111786d into rust-lang:master May 9, 2018

est31 mentioned this pull request May 15, 2018

Rust 1.26.1 point release #50756

Closed

Update RELEASES.md for 1.26.0 #49523

Update RELEASES.md for 1.26.0 #49523

Conversation

XAMPPRocky commented Mar 30, 2018

mark-i-m commented Mar 30, 2018

mark-i-m commented Mar 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottmcm Mar 31, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mark-i-m Apr 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kennytm commented Apr 2, 2018

tmccombs commented Apr 2, 2018

kennytm commented Apr 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kennytm commented Apr 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XAMPPRocky commented May 1, 2018

ollie27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XAMPPRocky commented May 4, 2018

ollie27 commented May 6, 2018

Mark-Simulacrum commented May 7, 2018

bors commented May 7, 2018

kennytm commented May 9, 2018 • edited Loading

kennytm commented May 9, 2018

bors commented May 9, 2018

scottmcm Mar 31, 2018 •

edited

Loading

mark-i-m Apr 2, 2018 •

edited

Loading

kennytm commented May 9, 2018 •

edited

Loading