Deprecate signed std::num::NonZeroI* with a call for use cases #49324
Conversation
SimonSapin
added
the
T-libs-api
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
I think these were added a few nighties ago, right? If so it may be fine to just delete them |
|
Yeah I agree that’d be fine in terms of breakage, but keeping them with a warning gets us a way to specifically ask people to comment on the tracking issue. I’m not too sure that’s really useful though. What do you think? |
src/libcore/num/mod.rs
Outdated
| NonZeroU128(u128); NonZeroI128(i128); | ||
| #[rustc_deprecated(since = "1.26.0", reason = "\ | ||
| signed non-zero integers are considered for removal due to lack of known use cases. \ | ||
| If you’re using them, please comment on https://github.com/serde-rs/serde/pull/1191")] |
There was a problem hiding this comment.
Did you mean to reference serde here?
There was a problem hiding this comment.
Oops :) Fixed, thanks.
|
Discussed in person with Alex @bors: r=alexcrichton |
|
📌 Commit cea018f has been approved by |
bors
added
S-waiting-on-bors
Deprecate signed std::num::NonZeroI* with a call for use cases CC #49137 (comment)
|
☀️ Test successful - status-appveyor, status-travis |
CC #49137 (comment)