Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: Tweak where timing information goes #49089

Merged
merged 1 commit into from
Mar 24, 2018
Merged

rustbuild: Tweak where timing information goes #49089

merged 1 commit into from
Mar 24, 2018

Conversation

alexcrichton
Copy link
Member

This commit tweaks where timing and step information is printed out as part of
the build, ensuring that we do it as close to the location where work happens as
possible. In rustbuild various functions may perform long blocking work as
dependencies are assembled, so if we print out timing information early on we
may accidentally time more than just the step we were intending to time!

@alexcrichton
Copy link
Member Author

r? @Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Mar 16, 2018

☔ The latest upstream changes (presumably #48097) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 16, 2018
@alexcrichton
rustbuild: Tweak where timing information goes
6fd4d67 
This commit tweaks where timing and step information is printed out as part of
the build, ensuring that we do it as close to the location where work happens as
possible. In rustbuild various functions may perform long blocking work as
dependencies are assembled, so if we print out timing information early on we
may accidentally time more than just the step we were intending to time!
@shepmaster shepmaster added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2018
@shepmaster
Copy link
Member

Ping from triage @Mark-Simulacrum !

@Mark-Simulacrum
Copy link
Member

@bors r+

cc @kennytm feel free to prioritize this if we want it to land before all-hands

@bors
Copy link
Contributor

bors commented Mar 23, 2018

📌 Commit 6fd4d67 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2018
@kennytm
Copy link
Member

kennytm commented Mar 23, 2018

Since this is just moving the travis_fold around, it doesn't seem to need prioritization. I'll keep it at p=0.

@alexcrichton
Copy link
Member Author

@bors: rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
@alexcrichton
Rollup merge of rust-lang#49089 - alexcrichton:fix-timings, r=Mark-Si…
d17afd1 
…mulacrum

rustbuild: Tweak where timing information goes

This commit tweaks where timing and step information is printed out as part of
the build, ensuring that we do it as close to the location where work happens as
possible. In rustbuild various functions may perform long blocking work as
dependencies are assembled, so if we print out timing information early on we
may accidentally time more than just the step we were intending to time!
@alexcrichton alexcrichton mentioned this pull request Mar 23, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49089 - alexcrichton:fix-timings, r=Mark-Si…
e551f24 
…mulacrum

rustbuild: Tweak where timing information goes

This commit tweaks where timing and step information is printed out as part of
the build, ensuring that we do it as close to the location where work happens as
possible. In rustbuild various functions may perform long blocking work as
dependencies are assembled, so if we print out timing information early on we
may accidentally time more than just the step we were intending to time!
@kennytm kennytm mentioned this pull request Mar 24, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49089 - alexcrichton:fix-timings, r=Mark-Si…
23b4bf9 
…mulacrum

rustbuild: Tweak where timing information goes

This commit tweaks where timing and step information is printed out as part of
the build, ensuring that we do it as close to the location where work happens as
possible. In rustbuild various functions may perform long blocking work as
dependencies are assembled, so if we print out timing information early on we
may accidentally time more than just the step we were intending to time!
@kennytm kennytm mentioned this pull request Mar 24, 2018
Merged
bors added a commit that referenced this pull request Mar 24, 2018
@bors
Auto merge of #49337 - kennytm:rollup, r=kennytm
f5631d9 
Rollup of 21 pull requests

- Successful merges: #49046, #49076, #49089, #49120, #49121, #49122, #49162, #49193, #49194, #49203, #49229, #49235, #49254, #49268, #49273, #49274, #49290, #49312, #49314, #49318, #49299
@bors bors merged commit 6fd4d67 into rust-lang:master Mar 24, 2018
@alexcrichton alexcrichton deleted the fix-timings branch March 30, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @bors @shepmaster @Mark-Simulacrum @kennytm