Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto-toolstate][2+3/8] Move external tools tests into its own job with --no-fail-fast #46393

Merged

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Nov 30, 2017

This PR performs these things:

  1. The aux job now performs "cargotest" and "pretty" tests. The clippy/rustfmt/rls/miri tests are moved into its own job.
  2. These tests are run with --no-fail-fast, so that we can get the maximum number of failures of all tools from a single CI run.
  3. The test results are stored into a JSON file, ready to be uploaded in the future.

This is step 2 and 3/8 of automatic management of broken tools #45861.

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 30, 2017
@kennytm kennytm force-pushed the 45861-step-2-3-make-tools-job-not-fail-fast branch 15 times, most recently from 5e36d9c to 5cf368a Compare November 30, 2017 17:46
@kennytm kennytm changed the title [WIP] [auto-toolstate][2+3/8] Move external tools tests into its own job with --no-fail-fast [auto-toolstate][2+3/8] Move external tools tests into its own job with --no-fail-fast Nov 30, 2017
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2017
@kennytm
Copy link
Member Author

kennytm commented Nov 30, 2017

r? @alexcrichton

cc @nrc

@alexcrichton
Copy link
Member

@bors: r+

Looks fantastic, thanks @kennytm!

@bors
Copy link
Contributor

bors commented Nov 30, 2017

📌 Commit 5cf368a has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2017
@bors
Copy link
Contributor

bors commented Dec 3, 2017

⌛ Testing commit 5cf368a1e560131af48f5f7d877c512f3c32ebbd with merge 33b67152932620802d845805f16c9739ea44c6ff...

@bors
Copy link
Contributor

bors commented Dec 3, 2017

💔 Test failed - status-appveyor

@kennytm kennytm force-pushed the 45861-step-2-3-make-tools-job-not-fail-fast branch from 5cf368a to b52fc12 Compare December 3, 2017 08:28
@kennytm
Copy link
Member Author

kennytm commented Dec 3, 2017

@bors r=alexcrichton

Windows folder separator + Bash = 😱

@bors
Copy link
Contributor

bors commented Dec 3, 2017

📌 Commit b52fc12 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 3, 2017

⌛ Testing commit b52fc127a1fedfda80d8064cd6be8b6e72b5197e with merge 24ded9606540ef195d29a09cb6ec638effb4e73b...

@bors
Copy link
Contributor

bors commented Dec 3, 2017

💔 Test failed - status-appveyor

@kennytm kennytm force-pushed the 45861-step-2-3-make-tools-job-not-fail-fast branch from b52fc12 to 1839645 Compare December 3, 2017 10:37
@kennytm
Copy link
Member Author

kennytm commented Dec 3, 2017

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Dec 3, 2017

📌 Commit 1839645 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 3, 2017

⌛ Testing commit 1839645 with merge f2b11f3...

bors added a commit that referenced this pull request Dec 3, 2017
…-fast, r=alexcrichton

[auto-toolstate][2+3/8] Move external tools tests into its own job with --no-fail-fast

This PR performs these  things:

1. The `aux` job now performs "cargotest" and "pretty" tests. The clippy/rustfmt/rls/miri tests are moved into its own job.
2. These tests are run with `--no-fail-fast`, so that we can get the maximum number of failures of all tools from a single CI run.
3. The test results are stored into a JSON file, ready to be uploaded in the future.

This is step 2 and 3/8 of automatic management of broken tools #45861.
@bors
Copy link
Contributor

bors commented Dec 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing f2b11f3 to master...

@bors bors merged commit 1839645 into rust-lang:master Dec 3, 2017
@kennytm kennytm deleted the 45861-step-2-3-make-tools-job-not-fail-fast branch December 4, 2017 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants