Use suggestions instead of notes ref mismatches #46256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-waiting-on-review
estebank
force-pushed
the
suggest-deref
branch
from
3b8b4a2 to
a55f181
Compare
|
@bors r+ |
|
📌 Commit a55f181 has been approved by |
kennytm
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #46168) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
force-pushed
the
suggest-deref
branch
from
a55f181 to
e457cbd
Compare
|
@bors r=arielb1 |
|
📌 Commit e457cbd has been approved by |
|
⌛ Testing commit e457cbd with merge 033288f8bbe1831f2538bf7b356433d9e7cd147a... |
|
💔 Test failed - status-travis |
|
@bors retry — travis-ci/travis-ci#8821 |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
Use suggestions instead of notes ref mismatches On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
kennytm
added
S-waiting-on-author
estebank
force-pushed
the
suggest-deref
branch
from
e457cbd to
4af5054
Compare
kennytm
added
the
S-waiting-on-review
kennytm
removed
the
S-waiting-on-author
On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
estebank
force-pushed
the
suggest-deref
branch
from
4af5054 to
36faafe
Compare
|
Rebased against latest master. @bors r=arielb1 |
|
📌 Commit 36faafe has been approved by |
estebank
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 2, 2017
Use suggestions instead of notes ref mismatches On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On type mismatch errors, use a suggestion when encountering minimal
differences in type differences due to refs, instead of a note.