Emit crate disambiguators in save-analysis data

[Xanewok]

Needed for rust-dev-tools/rls-analysis#93.
Blocked by rust-dev-tools/rls-data#11. (For now, this pulls my branch rls-data/crate-source)

This will allow to disambiguate different crates types/versions when indexing resulting save-analysis data (most importantly allow to support bin+lib and different crate versions).

r? @nrc

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[bors]

☔ The latest upstream changes (presumably #45096) made this pull request unmergeable. Please resolve the merge conflicts.

[nrc]

r+ once the rls-data PR lands and using the new rls-data version.

[Xanewok]

Resolved conflict and updated version using rls-data 0.12

[kennytm]

@Xanewok Is this PR still [WIP], or is it ready to be merged? 🙂

[Xanewok]

@kennytm it's ready!
@nrc in these cases should I do something like r=nrc with bors?

[nrc]

@bors: r+

[bors]

📌 Commit 45fa7b2 has been approved by nrc

[bors]

⌛ Testing commit 45fa7b2 with merge e0108b32a832227c30ffdb285fe2162e85dba3fa...

[bors]

💔 Test failed - status-appveyor

[Xanewok]

@nrc this failed on compiling rls (rls-data mismatch).
The rls needs to pull new rls-data 0.12, but with that it needs also the updated rls-analysis (PR pending rust-dev-tools/rls-analysis#106).
I pushed a branch upstream with a patch for rls: https://github.com/rust-lang-nursery/rls/tree/multiple-analysis, but that still has to pull my custom branch - not sure if rustbuild with --frozen will let me do that.

What should we do here to resolve this?

[Xanewok]

Updating rls submodule to rust-45468 branch, so it can compile with these changes.

[nrc]

@bors: r+

[bors]

📌 Commit 930464e has been approved by nrc

[bors]

⌛ Testing commit 930464e1884b351fbd1664597a5869cb94dfc432 with merge 3e2d634482aba5a01ee874915c1798107d7d90aa...

[bors]

💔 Test failed - status-appveyor

[Xanewok]

single test in rls failed:

failures:
---- server::test::test_use_root_uri stdout ----
	thread 'server::test::test_use_root_uri' panicked at 'Could not convert URI to path: ()', src\libcore\result.rs:906:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    server::test::test_use_root_uri
test result: FAILED. 27 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '--bin rls'

[nrc]

@bors: r+

[bors]

📌 Commit b4ffede has been approved by nrc

[bors]

⌛ Testing commit b4ffede with merge b56c5189726be531377b3aa39b3ea98b4f214f43...

[bors]

💔 Test failed - status-travis

[Xanewok]

arm-android CI build hung up on libstd test:

No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.

[kennytm]

@bors retry #43283

[01:28:23] test process::tests::test_process_output_fail_to_start has been running for over 60 seconds


No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

[bors]

⌛ Testing commit b4ffede with merge 2379faa...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing 2379faa to master...