Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to clear out the stageN-{rustc,std,tools} directories. #44792

Merged
merged 2 commits into from
Oct 20, 2017

Commits on Oct 18, 2017

  1. Make sure to clear out the stageN-{rustc,std,tools} directories.

    We copy built tool binaries into a dedicated directory to avoid deleting
    them, stageN-tools-bin. These aren't ever cleared out by code, since
    there should be no reason to do so, and we'll simply overwrite them as
    necessary.
    
    When clearing out the stageN-{std,rustc,tools} directories, make sure to
    delete both Cargo directories -- per-target and build scripts. This
    ensures that changing libstd doesn't cause problems due to build scripts
    not being rebuilt, even though they should be.
    Mark-Simulacrum committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    0fcd3e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2017

  1. Make tools which may not build return Option.

    This makes it mandatory for other steps to have to handle the potential
    failure instead of failing in an odd way later down the road.
    Mark-Simulacrum committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    686c101 View commit details
    Browse the repository at this point in the history