Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilized vec_splice and modified splice tracking issue #44640

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Stabilized vec_splice and modified splice tracking issue #44640

merged 2 commits into from
Sep 18, 2017

Conversation

budziq
Copy link
Contributor

@budziq budziq commented Sep 17, 2017 •
edited
Loading

This stabilizes the vec_splice (Vec part of splice RFC)
Fixes #32310.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Mark-Simulacrum Mark-Simulacrum changed the title stabilized splice (fixes #32310) Stabilized splice Sep 17, 2017
@dtolnay dtolnay assigned dtolnay and unassigned BurntSushi Sep 17, 2017
dtolnay
dtolnay requested changes Sep 17, 2017
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it isn't clear from the tracking issue -- but when the libs team discussed stabilizing Vec::splice and String::splice, we decided to stabilize Vec::splice but try a new signature for String::splice and keep it unstable. I left a comment on the tracking issue just now to clarify this.

Please keep the unstable attribute on String::splice for now and change its tracking issue number to point to #44643. Since we are stabilizing one but not the other, they will need to have different feature names. We can minimize breakage by changing Vec::splice to be under the now-stable feature vec_splice and keeping String::splice under feature(splice).

#[stable(feature = "vec_splice", since = "1.22.0")]
#[unstable(feature = "splice", reason = "...", issue = "44643")]

Thanks!

@budziq
Copy link
Contributor Author

budziq commented Sep 17, 2017

Thanks for the heads-up! I'll do it later today.

@budziq budziq changed the title Stabilized splice Stabilized vec_splice and modified splice tracking issue Sep 17, 2017
@budziq
Copy link
Contributor Author

budziq commented Sep 17, 2017

@dtolnay Done!

@dtolnay
Copy link
Member

dtolnay commented Sep 17, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 17, 2017

📌 Commit 6b167f9 has been approved by dtolnay

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 18, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge of rust-lang#44640 - budziq:stabilize_splice, r=dtolnay
054a46e 
Stabilized vec_splice and modified splice tracking issue

This stabilizes the vec_splice (Vec part of splice RFC)
Fixes rust-lang#32310.
@alexcrichton alexcrichton mentioned this pull request Sep 18, 2017
Closed
bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of #44676 - alexcrichton:rollup, r=alexcrichton
4a8bc8a 
Rollup of 10 pull requests

- Successful merges: #44364, #44466, #44537, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
@alexcrichton
Rollup merge of rust-lang#44640 - budziq:stabilize_splice, r=dtolnay
fa9dd27 
Stabilized vec_splice and modified splice tracking issue

This stabilizes the vec_splice (Vec part of splice RFC)
Fixes rust-lang#32310.
@alexcrichton alexcrichton mentioned this pull request Sep 18, 2017
Merged
bors added a commit that referenced this pull request Sep 18, 2017
@bors
Auto merge of #44678 - alexcrichton:rollup, r=alexcrichton
0701b37 
Rollup of 11 pull requests

- Successful merges: #44364, #44466, #44537, #44548, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
@bors bors merged commit 6b167f9 into rust-lang:master Sep 18, 2017
@Manishearth Manishearth mentioned this pull request Sep 21, 2017
Closed
@dtolnay dtolnay added relnotes Marks issues that should be documented in the release notes of the next release. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2017
@dtolnay dtolnay mentioned this pull request Sep 21, 2017
Merged
@dtolnay dtolnay added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 21, 2017
dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017
@dtolnay
Backport libs stabilizations to 1.21 beta
874124b 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
This was referenced Sep 25, 2017
Merged
Closed
dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 26, 2017
@dtolnay
Backport libs stabilizations to 1.21 beta
a8117df 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
bors added a commit that referenced this pull request Sep 26, 2017
@bors
Auto merge of #44823 - dtolnay:backport21, r=alexcrichton
3c3cd3f 
[beta] Backport accepted PRs to 1.21

Backport of:

- ~don't suggest placing `use` statements into expanded code #44215
- stabilize tcpstream_connect_timeout #44563
- stabilized iterator_for_each #44567
- travis: Move sccache to the us-west-1 region #44574
- stabilized ord_max_min #44593
- stabilized compiler_fences #44595
- ci: Upload/download from a new S3 bucket #44617
- stabilized needs_drop #44639
- Stabilized vec_splice and modified splice tracking issue #44640
- Backport libs stabilizations to 1.21 beta #44824
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44824 - dtolnay:22really21, r=alexcrichton
570f1ce 
Backport libs stabilizations to 1.21 beta

Includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640

These have been backported in rust-lang#44823.
@dtolnay dtolnay mentioned this pull request Oct 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@budziq @rust-highfive @dtolnay @bors @carols10cents @BurntSushi