Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sometimes in std::io::Read doc #42685

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented Jun 15, 2017

We use it immediately in the next sentence, and the word is filler.

A different conversation to make is whether we want to call them Readers in the documentation at all. And whether it's actually called "Readers" elsewhere.

We use it immediately in the next sentence, and the word is filler.
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@Havvy
Copy link
Contributor Author

Havvy commented Jun 15, 2017

Always forget the r? part.

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Jun 15, 2017
@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks!

@bors
Copy link
Contributor

bors commented Jun 15, 2017

📌 Commit edd3cd8 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 16, 2017
…klabnik

Remove sometimes in std::io::Read doc

We use it immediately in the next sentence, and the word is filler.

A different conversation to make is whether we want to call them Readers in the documentation at all. And whether it's actually called "Readers" elsewhere.
bors added a commit that referenced this pull request Jun 16, 2017
Rollup of 5 pull requests

- Successful merges: #42616, #42651, #42654, #42656, #42685
- Failed merges:
@bors bors merged commit edd3cd8 into rust-lang:master Jun 16, 2017
@Havvy Havvy deleted the doc-remove-sometimes branch September 27, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants