Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better docs #42409

Merged
merged 8 commits into from
Jun 7, 2017
Merged

Better docs #42409

merged 8 commits into from
Jun 7, 2017

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jun 3, 2017 •
edited
Loading

Working on more doc improvements

Edit: done for today

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

bjorn3
bjorn3 commented Jun 3, 2017
View reviewed changes
src/librustc/infer/region_inference/graphviz.rs
@@ -133,7 +133,6 @@ enum Node {
Region(ty::RegionKind),
}

// type Edge = Constraint;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

@bjorn3
Copy link
Member Author

bjorn3 commented Jun 3, 2017

Ready for review

@frewsxcv
Copy link
Member

frewsxcv commented Jun 3, 2017 

tidy check (x86_64-unknown-linux-gnu)
[00:02:18] tidy error: /checkout/src/librustc/hir/def.rs:166: trailing whitespace
[00:02:18] tidy error: /checkout/src/librustc/hir/lowering.rs:73: trailing whitespace
[00:02:18] tidy error: /checkout/src/librustc/hir/lowering.rs:76: trailing whitespace
[00:02:18] tidy error: /checkout/src/librustc/infer/region_inference/mod.rs:232: trailing whitespace
[00:02:20] some tidy checks failed

@frewsxcv frewsxcv changed the title [WIP] Better docs Better docs Jun 3, 2017
@frewsxcv frewsxcv added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 3, 2017
@bjorn3
Copy link
Member Author

bjorn3 commented Jun 4, 2017

Fixed tidy errors

@frewsxcv
Copy link
Member

frewsxcv commented Jun 7, 2017

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 7, 2017

📌 Commit 949b2a3 has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 7, 2017
@frewsxcv
Rollup merge of rust-lang#42409 - bjorn3:patch-3, r=frewsxcv
e702b75 
Better docs

Working on more doc improvements

Edit: done for today
@frewsxcv frewsxcv mentioned this pull request Jun 7, 2017
Merged
bors added a commit that referenced this pull request Jun 7, 2017
@bors
Auto merge of #42494 - frewsxcv:rollup, r=frewsxcv
f73f675 
Rollup of 7 pull requests

- Successful merges: #42409, #42415, #42429, #42438, #42466, #42469, #42485
- Failed merges:
@bors bors merged commit 949b2a3 into rust-lang:master Jun 7, 2017
@bjorn3 bjorn3 deleted the patch-3 branch June 8, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rust-highfive @frewsxcv @bors @eddyb