bootstrap: Make bootstrap verbose if requested #42186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
devurandom
force-pushed
the
fix/bootstrap-verbose
branch
3 times, most recently
from
310e6e2
to
2d5ba56
Compare
devurandom
changed the title
kennytm
reviewed
May 24, 2017
src/bootstrap/bootstrap.py
Outdated
| @@ -620,6 +618,11 @@ def bootstrap(): | |||
| except: | |||
| pass | |||
|
|
|||
| if '\nverbose = 2' in rb.config_toml: | |||
| rb.verbose = 2 | |||
| else if '\nverbose = 1' in rb.config_toml: | |||
There was a problem hiding this comment.
Thanks! Fixed in 2aa6700.
Wonder how this slipped through, though. I ran the build here without it stumbling over that SyntaxError...
This brings verbosity even to invocation of cargo itself
devurandom
force-pushed
the
fix/bootstrap-verbose
branch
from
2d5ba56
to
cd86a9b
Compare
|
@bors: r+ Thanks @devurandom! |
|
📌 Commit cd86a9b has been approved by |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
…=alexcrichton bootstrap: Make bootstrap verbose if requested Fixes: rust-lang#42099
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
…=alexcrichton bootstrap: Make bootstrap verbose if requested Fixes: rust-lang#42099
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
…=alexcrichton bootstrap: Make bootstrap verbose if requested Fixes: rust-lang#42099
bors
added a commit
that referenced
this pull request
May 24, 2017
aidanhs
added
the
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 25, 2017
…=alexcrichton bootstrap: Make bootstrap verbose if requested Fixes: rust-lang#42099
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 25, 2017
…=alexcrichton bootstrap: Make bootstrap verbose if requested Fixes: rust-lang#42099
bors
added a commit
that referenced
this pull request
May 25, 2017
devurandom
added a commit
to devurandom/gentoo-overlay
that referenced
this pull request
Jun 5, 2017
Use Cargo PV[minor]+1, as the tarball for Cargo 0.17 is broken: It contains a directory that is called "nightly" instead of the actual version number. Add patch to make bootstrap verbose rust-lang/rust#42186 Add patch to output config file location on failure rust-lang/rust#41820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #42099