Update rustc-ux-guidelines #41836
Update rustc-ux-guidelines #41836
Conversation
jz0425
commented
May 8, 2017
jz0425
commented
- changed "long way into" to "long way toward"
- changed "developer lives" to "developers' lives"
- removed the "either... or..." format from second paragraph because there are more than 2 options
- Minor revisions to paragraphs 3-6 to make them more consistent in format and to fix minor grammar issues.
1) changed "long way into" to "long way toward" 2) changed "developer lives" to "developers' lives" 3) removed the "either... or..." format from second paragraph because there are more than 2 options 4) Minor revisions to paragraphs 3-6 to make them more consistent in format and to fix minor grammar issues.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @frewsxcv (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Mark-Simulacrum
added
the
S-waiting-on-review
|
Thanks for the contribution! I think the title of your PR was copy pasted incorrectly, though. Changes look good to me, but I'll leave to @frewsxcv for an official review. |
src/doc/rustc-ux-guidelines.md
Outdated
| information to the user about how to solve their problem. | ||
|
|
||
| A `note` is for identifying additional circumstances and parts of the code | ||
| that lead to a warning or error. For example, the borrow checker will note any | ||
| A `note` to emitted to identify additional circumstances and parts of the code |
There was a problem hiding this comment.
A
noteto emitted to identify...
The wording here seems a little off and I'm having trouble understanding the intention. Maybe you mean:
A
noteis emitted to identify...
There was a problem hiding this comment.
Yes, that is what I meant, thanks for the catch. Should I update and do a new PR?
"A `note` to emitted to" changed to "A `note` is emitted to"
|
thanks for these improvements! @bors r+ rollup |
|
📌 Commit 9b8f9b7 has been approved by |
@bors: r+ 38fe8d2 rollup 1) changed "long way into" to "long way toward" 2) changed "developer lives" to "developers' lives" 3) removed the "either... or..." format from second paragraph because there are more than 2 options 4) Minor revisions to paragraphs 3-6 to make them more consistent in format and to fix minor grammar issues.
