Removal pass for anonymous parameters #41693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes occurences of anonymous parameters from the rustc codebase, as they are to be deprecated. See issue rust-lang#41686 and RFC 1685.
|
r? @eddyb |
eddyb
approved these changes
May 2, 2017
src/libcore/convert.rs
Outdated
| @@ -276,7 +276,7 @@ pub trait Into<T>: Sized { | |||
| pub trait From<T>: Sized { | |||
| /// Performs the conversion. | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| fn from(T) -> Self; | |||
| fn from(t: T) -> Self; | |||
There was a problem hiding this comment.
IMO t is unidiomatic. I personally prefer x. Or _ like you used elsewhere.
src/librustdoc/html/highlight.rs
Outdated
| fn string<T: Display>(&mut self, | ||
| text: T, | ||
| klass: Class, | ||
| tas: Option<&TokenAndSpan>) |
There was a problem hiding this comment.
tok or token feel better suited IMO.
|
@bors r+ |
|
📌 Commit 14bbd0a has been approved by |
arielb1
added
the
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
May 2, 2017
Removal pass for anonymous parameters Removes occurences of anonymous parameters from the rustc codebase, as they are to be deprecated. See issue rust-lang#41686 and RFC 1685. r? @frewsxcv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes occurences of anonymous parameters from the
rustc codebase, as they are to be deprecated.
See issue #41686 and RFC 1685.
r? @frewsxcv