-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to fcntl
if ioctl(FIOCLEX, ..)
is unsupported
#41462
Conversation
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
cc @rust-lang/libs |
Thanks for the PR! We’ll periodically check in on it to make sure that @BurntSushi or someone else from the team reviews it soon. |
@tbu- Sorry, I'm missing a lot of context here. I don't have any idea what this change actually does or what problem it solves. Could you perhaps say more about what's happening here? |
@BurntSushi If you see the linked issue, this change is trying to provide support for faux-linux systems that don't support the |
Could you expand the description in the PR to describe the problem? And can you also leave a comment as to why the code is structured the way it is? I'd personally prefer to not go too far down the road of supporting pre-2.6.18 Linux kernels, so is this literally intended to support Linux 2.4 or is it portability to Esxi? |
Could you describe which kernels are you trying to support with this PR? |
This was just trying to fix the issue that was encountered in #41437. I don't know if it needs other stuff as well. I'm not affected by this, so I'm not too attached to this patch. |
Ok, in that case I'm personally inclined to hold off for now. We don't know if the target in #41347 actually warrants an entirely new compiler target or if this change is enough to get the program working. In light of that it seems like it may be premature to do this? |
OK. |
Fixes #41347.