-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up @carols10cents' mailmap entry #39345
Conversation
The previous ways didn't work; this does. cc rust-lang-nursery/thanks#45
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit 0f2a5f6 has been approved by |
I don't think this will work. According to the manual page one person should always have one line, with the preffered name and email at the start, and any other (or previous) names and emails following in the same line. Also, if somebody used the same email but a different name, it counts as different person, so it needs to be inside the line as well. Deleting a name from the mailmap won't help, as the name is still mentioned in the git history of rustc. |
Mhh, testing |
I checked this locally; before this change, both her names are in there, afterwards, there's only one. I share your confusion about the man page. |
…richton Fix up @carols10cents' mailmap entry The previous ways didn't work; this does. cc rust-lang-nursery/thanks#45
@bors rollup |
The previous ways didn't work; this does.
cc rust-lang-nursery/thanks#45