Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Don't build docs for misc facade crates #38658

Merged
merged 1 commit into from
Dec 30, 2016

Conversation

alexcrichton
Copy link
Member

Retain the same behavior as stable.

Closes #38319

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 28, 2016
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

Nominating for a beta backport due to #38319

@ollie27
Copy link
Member

ollie27 commented Dec 28, 2016

What about compiler_builtins and std_shim?

Do you think we can stop including the docs for libc while we're at it?

@alexcrichton
Copy link
Member Author

Oh I didn't see those on https://doc.rust-lang.org/beta/std/ but I see them now on nightly, I'll update accordingly. Also yeah let's axe the libc docs.

@nikomatsakis nikomatsakis added beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 30, 2016
@nikomatsakis
Copy link
Contributor

Marked as beta-accepted (cc @rust-lang/compiler -- though this could also be considered @rust-lang/tools; in any case the patch seems clearly ok to backport)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2016

📌 Commit 03c6e7d has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Dec 30, 2016

⌛ Testing commit 03c6e7d with merge f6b266d...

@bors
Copy link
Contributor

bors commented Dec 30, 2016

💔 Test failed - status-travis

@nikomatsakis
Copy link
Contributor

@alexcrichton

looks legitimate:

book/error-handling.html:1395: broken link - std/macro.try.html
book/error-handling.html:1463: broken link - std/error/trait.Error.html
book/error-handling.html:1464: broken link - std/error/trait.Error.html
book/error-handling.html:1584: broken link - std/io/enum.ErrorKind.html
book/error-handling.html:1585: broken link - std/num/struct.ParseIntError.html
book/error-handling.html:1591: broken link - std/error/trait.Error.html
book/error-handling.html:1607: broken link - std/io/type.Result.html
book/error-handling.html:1608: broken link - std/fmt/type.Result.html
book/error-handling.html:1795: broken link - std/fs/struct.File.html
book/error-handling.html:1797: broken link - std/io/struct.Error.html
book/error-handling.html:1951: broken link - std/convert/trait.From.html
book/error-handling.html:2245: broken link - std/result/enum.Result.html
book/error-handling.html:2246: broken link - std/option/enum.Option.html
book/error-handling.html:2248: broken link - std/option/enum.Option.html
book/error-handling.html:2258: broken link - std/convert/trait.From.html
book/error-handling.html:2260: broken link - std/error/trait.Error.html
book/error-handling.html:2261: broken link - std/macro.try.html
book/error-handling.html:2265: broken link - std/error/trait.Error.html
book/error-handling.html:2267: broken link - std/convert/trait.From.html
book/error-handling.html:2272: broken link - std/option/enum.Option.html
book/error-handling.html:2274: broken link - std/result/enum.Result.html
book/concurrency.html:205: broken link - std/marker/trait.Send.html
book/concurrency.html:219: broken link - std/marker/trait.Sync.html
book/concurrency.html:494: broken link - std/sync/struct.Mutex.html
book/concurrency.html:495: broken link - std/sync/struct.Mutex.html
error-index.html:7: broken link - main.css
thread 'main' panicked at 'found some broken links', /checkout/src/tools/linkchecker/main.rs:49
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Retain the same behavior as stable.

Closes rust-lang#38319
@alexcrichton
Copy link
Member Author

Man linkchecker is a lifesaver. That just caught a bug where we built no documentation at all!

@bors: r=nikomatsakis

@bors
Copy link
Contributor

bors commented Dec 30, 2016

📌 Commit a8535ce has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Dec 30, 2016

⌛ Testing commit a8535ce with merge 6c9bb42...

bors added a commit that referenced this pull request Dec 30, 2016
std: Don't build docs for misc facade crates

Retain the same behavior as stable.

Closes #38319
@bors
Copy link
Contributor

bors commented Dec 30, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 6c9bb42 to master...

@bors bors merged commit a8535ce into rust-lang:master Dec 30, 2016
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 30, 2016
@alexcrichton alexcrichton deleted the less-docs branch January 1, 2017 00:24
@ollie27
Copy link
Member

ollie27 commented Jan 2, 2017

This doesn't seem to have worked: https://doc.rust-lang.org/nightly/std/. The docs for std_shim are no longer generated but the rest still are. I've tested this locally as well and got the same results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants