Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Ctrl+C in the build script #38299

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Handle Ctrl+C in the build script #38299

merged 1 commit into from
Dec 13, 2016

Conversation

achanda
Copy link
Contributor

@achanda achanda commented Dec 11, 2016

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Thanks for the PR! We want to be sure to kill the subprocess as well, though, so can you confirm that the call to the build system is killed?

@achanda
Copy link
Contributor Author

achanda commented Dec 11, 2016

@alexcrichton I just checked, all sub processes are killed on a Ctrl+C. Feel free to cross check though!

@brson
Copy link
Contributor

brson commented Dec 11, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 11, 2016

📌 Commit b7cd840 has been approved by brson

@achanda
Copy link
Contributor Author

achanda commented Dec 12, 2016

Not sure why the test failed. I don't see any indications in https://travis-ci.org/rust-lang/rust/jobs/183028434 . Should we just retry?

@petrochenkov
Copy link
Contributor

@achanda
Travis tests status isn't taken into account when merging, it's only informative (all Travis testing is also broken at the moment).
You can see the actual status of this PR in https://buildbot.rust-lang.org/homu/queue/rust - it it's still in the queue and hasn't failed, so there's no need to retry.

@achanda
Copy link
Contributor Author

achanda commented Dec 12, 2016

I see, thanks!

@frewsxcv frewsxcv mentioned this pull request Dec 12, 2016
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 12, 2016
@frewsxcv
Rollup merge of rust-lang#38299 - achanda:ctrl-c, r=brson
1a2e37c 
Handle Ctrl+C in the build script
@frewsxcv frewsxcv mentioned this pull request Dec 12, 2016
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 12, 2016
@frewsxcv
Rollup merge of rust-lang#38299 - achanda:ctrl-c, r=brson
cba1304 
Handle Ctrl+C in the build script
bors added a commit that referenced this pull request Dec 13, 2016
@bors
Auto merge of #38325 - frewsxcv:rollup, r=frewsxcv
5a2b50b 
Rollup of 7 pull requests

- Successful merges: #37052, #37941, #38067, #38164, #38202, #38264, #38299
- Failed merges:
@bors bors merged commit b7cd840 into rust-lang:master Dec 13, 2016
@achanda achanda deleted the ctrl-c branch December 13, 2016 08:40
@petrochenkov
Copy link
Contributor

@achanda
What was the goal of this patch?
KeyboardInterrupt is caught only to exit successfully (with exit code 0), this doesn't seem right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@achanda @rust-highfive @alexcrichton @brson @bors @petrochenkov @nikomatsakis