-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the docs for Error::description #37189
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
/// It should not contain newlines or sentence-ending punctuation, | ||
/// to facilitate embedding in larger user-facing strings. | ||
/// For showing formatted error messages with more information see | ||
/// (Display)[https://doc.rust-lang.org/std/fmt/trait.Display.html]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown links work the other way around: [text](url)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
/// It should not contain newlines or sentence-ending punctuation, | ||
/// to facilitate embedding in larger user-facing strings. | ||
/// For showing formatted error messages with more information see | ||
/// [Display](https://doc.rust-lang.org/std/fmt/trait.Display.html).s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to remove the 's' at the end of this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
Thank you! @bors r+ rollup |
📌 Commit 16b8957 has been approved by |
⌛ Testing commit 16b8957 with merge 3f6627b... |
💔 Test failed - auto-mac-64-opt-rustbuild |
@bluss This looks like a problem with the buildbot's git repository
|
Yes, it just happened to a whole bunch of PRs unfortunately. We'll retry this as soon as it's working again. |
@bors: retry |
Updated the docs for Error::description Fixes rust-lang#37163
Fixes #37163