Rollup of 10 pull requests #37170
Merged
Rollup of 10 pull requests #37170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sophiajt
commented
Oct 14, 2016
sophiajt
commented
- Successful merges: Changed error message E0408 to new format #36307, Explain motivation behind lifetimes #36755, Add missing urls for hash modules #36961, rustdoc: color the question mark operator #37102, add missing urls for BufWriter and BufReader #37115, book: remove backticks in Type Aliases header #37119, run rustfmt on liblog #37122, run rustfmt on libcore/num folder #37123, Documented that RwLock might panic #37141, add (missing) tar to list of packages to get under mingw #37159
- Failed merges:
The idea was proposed by eddyb in: rust-lang#31436 (comment)
Start the lifetime section with an explanation of the issues that lack of explicit lifetimes cause and how lifetimes alleviate these.
…uillaumeGomez Changed error message E0408 to new format Followed your text and was able to change the ouput to the new format. I did not encounter any broken test therefore this is a really small commit. Thanks for letting me hack on the compiler :) r? @jonathandturner
Explain motivation behind lifetimes Start the lifetime section with an explanation of the issues that lack of explicit lifetimes cause and how the explicit lifetimes solve these. ---------------- I had really hard time figuring out why I would need to care about the explicit reference lifetimes when going through the book at first. With strong background in C++, I'm familiar with the dangling reference problem - but given the section seems to focus more on the lifetime syntax and various ways to define lifetimes on functions and structs, I was unable to understand how they are used to solve the reference problem. This PR is an attempt at getting the reader to understand what the explicit lifetimes are used for and why they are an awesome thing instead of a bit of syntax that just has to be written. It's been less than a week that I've been diving into Rust so I'm far from certain about the terminology and technical correctness. I tried mimicking the existing terminology from the lifetimes section, but still no promises on getting it right.
Add missing urls for hash modules r? @steveklabnik
…laumeGomez rustdoc: color the question mark operator The idea of coloring `?` specially was proposed by @eddyb in: rust-lang#31436 (comment)
…mcallister add missing urls for BufWriter and BufReader r? @steveklabnik
book: remove backticks in Type Aliases header Fix rust-lang#37116.
run rustfmt on liblog
run rustfmt on libcore/num folder
Documented that RwLock might panic Fixes rust-lang#37010
…ichton add (missing) tar to list of packages to get under mingw The distribution targets use tar, but the readme pacman invocation doesn't include the tar package.
|
@bors r+ p=1 |
|
📌 Commit 881f0f8 has been approved by |
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.