-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove #[macro_escape]
.
#36603
Remove #[macro_escape]
.
#36603
Conversation
LGTM. @rust-lang/compiler, looks like this should've been removed before 1.0 - can we do that now? |
+1 |
☔ The latest upstream changes (presumably #36601) made this pull request unmergeable. Please resolve the merge conflicts. |
ping r? @eddyb, perhaps this should be nominated for a compiler team discussion? |
This is really a @rust-lang/compiler team problem. Wearing my compiler hat, I propose that we do a quick crater run to see if anyone is affected and remove it. Basically the normal bug fix protocol. At worst, we can have a warning period, but this seems like one of those cases where it's probably not needed. |
We can actually skip crater and just (rip)grep the sources of crates.io I guess, even easier. |
This looks like it removes all tests around |
@brson Currently,
It has been a deprecation warning since the beginning of 2015. At least one of the grepped crates ( |
Remove
#[macro_escape]
, which was deprecated at the end of 2014 (c.f 5bf385b).#[macro_escape]
is allowed with a deprecation warning on stable, so this is a [breaking-change].r? @eddyb