Revert "std: Cache HashMap keys in TLS" #36565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eaeef3d. This is a short-term workaround to rust-lang#36481.
sfackler
added
the
T-libs-api
|
Would it be safe to increment the seed on every creation? |
|
Note that HashMaps don't even call reserve in extend (issue #36579). Just fixing that would help some (don't know how much). |
|
@arthurprs see the discussion in #27243 for the nontrivial implications of doing that. |
|
As a heads up both Aaron and I are on PTO until next week, but I know I'd personally love to dig into this before merging time permitting. Just wanted to let you know it's not being intentionally ignored or anything! |
|
Cool, sounds good. |
|
Discussed in libs triage, our conclusion was to close this for now. We can take the next cycle to explore our options and otherwise resort to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit eaeef3d.
This is a short-term workaround to #36481.
r? @aturon
cc @rust-lang/libs