Workaround #34427 by using memset of 0 on ARM to set the discriminant. #36496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
approved these changes
Sep 15, 2016
|
@bors r+ |
|
📌 Commit 6950242 has been approved by |
nikomatsakis
added
the
beta-nominated
|
Nominated for beta. The regr is marked as "stable-to-stable", so I guess it at least affects beta. =) |
pnkfelix
added
the
T-compiler
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 15, 2016
…eddyb Workaround rust-lang#34427 by using memset of 0 on ARM to set the discriminant. Workaround rust-lang#34427 by using memset of 0 on ARM to set the discriminant.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 17, 2016
…eddyb Workaround rust-lang#34427 by using memset of 0 on ARM to set the discriminant. Workaround rust-lang#34427 by using memset of 0 on ARM to set the discriminant.
|
⌛ Testing commit 6950242 with merge c954ea8... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
Failure looks legit. @pnkfelix can you give this another look? |
|
@brson looking now |
pnkfelix
force-pushed
the
workaround-issue-34427
branch
from
6950242
to
c41a806
Compare
|
@dotdash pointed out that the size argument is target specific (which makes sense in hindsight). Trivial to fix, embarrassed I made the mistake. |
|
@bors r+ |
|
📌 Commit c41a806 has been approved by |
|
💥 Test timed out |
|
@bors retry |
Merged
Closed
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 21, 2016
…eddyb Workaround rust-lang#34427 by using memset of 0 on ARM to set the discriminant. Workaround rust-lang#34427 by using memset of 0 on ARM to set the discriminant.
Merged
brson
added a commit
that referenced
this pull request
Sep 21, 2016
brson
added
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround #34427 by using memset of 0 on ARM to set the discriminant.