-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center content of the generated docs #35682
Conversation
Screenshot is here. |
What's the motivation for this change? |
Another little improvement to documentation. Too much unused spaces. |
Amount of whitespace does not change, and with this change the mouse travel distance from sidebar/logo to the content and back increases significantly. |
@nagisa: It doesn't but it's better used. Also, I don't see the problem with the mouse travel distance. |
I like the original better. 👎 from me |
Putting this on the meeting agenda. |
Thanks @steveklabnik! |
Have you used anything other than a mouse to control the pointer? A pointing stick or a trackball? With these (and really, with any device), the less pointer has to move, the better. |
I use almost only my keyboard. |
I like the original better as well. If you wanted to improve readability, you could try setting |
☔ The latest upstream changes (presumably #35236) made this pull request unmergeable. Please resolve the merge conflicts. |
I prefer the original. The motivation doesn't line up with the implementation. If we're going to make a change, we should align it with a clear goal (e.g. "change markup to improve SEO" or "Add additional accessibility markup" or "Improve readability by setting width to 42em") |
Seems like most people are 👎 , so closing. Thanks anyway @GuillaumeGomez ❤️ |
r? @steveklabnik
cc @frewsxcv