Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed error message for enum variants #35260

Closed
wants to merge 1 commit into from
Closed

Changed error message for enum variants #35260

wants to merge 1 commit into from

Conversation

hilasha2
Copy link

@hilasha2 hilasha2 commented Aug 3, 2016

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2016

📌 Commit 820059e has been approved by nikomatsakis

@arielb1
Copy link
Contributor

arielb1 commented Aug 3, 2016

/build/src/librustc/infer/error_reporting.rs:523: trailing whitespace
/build/src/librustc/infer/error_reporting.rs:537: trailing whitespace
/build/src/librustc/infer/error_reporting.rs:550: trailing whitespace
/build/src/test/compile-fail/issue-35241.rs:37: trailing whitespace

That's annoying.

@bors r-

@arielb1
Copy link
Contributor

arielb1 commented Aug 4, 2016

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Aug 4, 2016

📌 Commit aaf5d5b has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Aug 4, 2016

⌛ Testing commit aaf5d5b with merge 60fca6a...

bors added a commit that referenced this pull request Aug 4, 2016
@bors bors mentioned this pull request Aug 4, 2016
@bors
Copy link
Contributor

bors commented Aug 4, 2016

💔 Test failed - auto-linux-64-debug-opt

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

@bors retry

@bors
Copy link
Contributor

bors commented Aug 4, 2016

⌛ Testing commit aaf5d5b with merge ca22f89...

bors added a commit that referenced this pull request Aug 4, 2016
@bors
Copy link
Contributor

bors commented Aug 5, 2016

💔 Test failed - auto-linux-64-debug-opt

@eddyb
Copy link
Member

eddyb commented Aug 25, 2016

@bors retry

@bors
Copy link
Contributor

bors commented Aug 25, 2016

⌛ Testing commit aaf5d5b with merge e7fa2a8...

@bors
Copy link
Contributor

bors commented Aug 25, 2016

💔 Test failed - auto-linux-64-cross-freebsd

@sophiajt
Copy link
Contributor

@bors r-

This looks like a legit failure:

error[E0531]: unresolved variant or struct `FnConverging`
   --> /buildslave/rust-buildbot/slave/auto-linux-64-cross-freebsd/build/src/librustc/infer/error_reporting.rs:543:22
    |
543 |                     (ty::FnConverging(ret_ty), _) => {
    |                      ^^^^^^^^^^^^^^^^

error[E0531]: unresolved variant, struct or constant `FnDiverging`
   --> /buildslave/rust-buildbot/slave/auto-linux-64-cross-freebsd/build/src/librustc/infer/error_reporting.rs:546:22
    |
546 |                     (ty::FnDiverging, _) => true
    |                      ^^^^^^^^^^^^^^^

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to resubmit with the test failure fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants