WIP: infrastructure for testing save-analysis

[aochagavia]

No description provided.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[aochagavia]

@alexcrichton Do I need to edit a makefile or something to let the new tests run?

@nrc Do you like the direction of this PR? I included a test example so you can see how it works.

[alexcrichton]

The easiest thing to do will probably be to modify rustbuild (src/bootstrap/build/{mod.rs,step.rs}) to include this test suite like the other compiletest test suites, but if you want it to run with make check on the makefiles you'll also have to modify mk/tests.mk. We run both suites on the bots so as long as it's run somewhere it's fine. (note that it won't get run currently, though).

I also personally liked the approach in #34481 of using annotations in the source as it seems much easier to write the test, but perhaps json was just easier to implement?

[nrc]

I do like the general approach. I think the example test should probably be less thorough to ensure that we are being a bit 'fuzzy'. E.g., just test that the function names exist and only test the line numbers, rather than the whole span or something. I would also like to see if we could include the JSON inline as a comment or something in the test file, I guess that could happen later if it is tricky.

[bors]

☔ The latest upstream changes (presumably #34552) made this pull request unmergeable. Please resolve the merge conflicts.

[alexcrichton]

Closing due to inactivity, but feel free to reopen with a rebase!