Rollup of 10 pull requests #33742
Merged
Rollup of 10 pull requests #33742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using closures that take references with explicit lifetimes sometimes it's required to use where F: for<..> ... syntax to express the right lifetimes. This adds a quick note to the docs so other users can discover it as well.
I'm guessing these were actually fixed with PR rust-lang#27085. Closes rust-lang#21225 Closes rust-lang#19197
Brings in a fix where `-lutil` is no longer passed for musl targets, lifting the need for a musl toolchain to be installed again. Closes rust-lang#33608
When displaying the function parameters for a lifetime elision error message, this changes it to first filter out the parameters that don't have elided lifetimes. Fixes rust-lang#30255.
Add error explanation for E0502 I am questioning the order of presentation on the suggested code fixes, but I'm not sure what would be best. Thoughts? r? @GuillaumeGomez
Add a note about Higher-Ranked Trait Bounds in docs on Closures. I hit a snag with lifetimes a few days ago and it wasn't until @birkenfeld pointed out Higher-Ranked Trait Bounds that I was able to solve the issue involving lifetimes on closure traits. This adds a small section in the book so that other users can find it. r? @steveklabnik
Add regression tests for error message when using enum variant as a type I'm guessing these were actually fixed with PR rust-lang#27085. Closes rust-lang#21225 Closes rust-lang#19197
std: Update libc submodule Brings in a fix where `-lutil` is no longer passed for musl targets, lifting the need for a musl toolchain to be installed again. Closes rust-lang#33608
…laumeGomez rustdoc: Make the #[stable(since)] version attribute clearer with a tooltip Rustdoc's new 'since' version placement only shows the version number in which the item was marked stable. This gains space but might make the meaning of this version string less clear in the docs, so I tried to bring some explicitness in a tooltip.
Only print parameters with elided lifetimes in elision error messages. When displaying the function parameters for a lifetime elision error message, this changes it to first filter out the parameters that don't have elided lifetimes. Fixes rust-lang#30255.
…g, r=nrc Fix bug in macro expression spans Fix a bug in macro expression spans. r? @nrc
…abnik Clarified that `let(mut x, y) =` only makes x mutable, not y Closes rust-lang#33716
…hts, r=Manishearth Rust syntax coloring for some ignore, should-panic and no-run snippets. In the book, some code blocks were missing the `rust` specifier which is needed for them to highlight correctly.
…ostics, r=nikomatsakis Fix macro expansion backtrace diagnostics Fixes rust-lang#33704. r? @nikomatsakis
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit acd2c11 has been approved by |
This was referenced May 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let(mut x, y) =only makes x mutable, not y #33720, Rust syntax coloring for some ignore, should-panic and no-run snippets. #33721, Fix macro expansion backtrace diagnostics #33730