-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename middle::ty::ctxt to TyCtxt #31979
Conversation
Why do we need namespaces if we are not using them? |
We need namespaces because we often do use them. That doesn't mean we should always avoid more descriptive names just because namespaces allow it. In this case, I decided to use |
@jseyfried you can write |
True, but I would prefer to be consistent with the other contexts. Also, that would make it harder to grep for all uses of |
cc @nikomatsakis There is that dual type context (w/ multiple lifetimes) refactor I wanted to do ages ago, which also renamed the context, but I used |
@jseyfried It wouldn't make harder to grep. Or I don't understood you. |
@KalitaAlexey You would have to grep for both |
Ok. You said |
☔ The latest upstream changes (presumably #31962) made this pull request unmergeable. Please resolve the merge conflicts. |
On Mon, Feb 29, 2016 at 11:48:26PM -0800, Eduard-Mihai Burtescu wrote:
It seems like the precedent is to call the type |
Well then, it's not like it could make refactorings any harder (actually, it should be easier to grep for |
8189937
to
5623a95
Compare
@eddyb rebased, the travis build is successful now |
@bors r+ |
📌 Commit 37ba66a has been approved by |
r? @eddyb