privacy: Permit pub items in blocks
#31919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that variant fields are not marked public by syntax extensions
|
@petrochenkov do you think we should add some new tests based on the examples you posted here: #31776 (comment) ? |
|
Both privacy in blocks, privacy in public etc are tested separately somewhere else, but I've added a new test with examples from #31776 (comment) just in case. |
|
@bors r+ |
|
📌 Commit b6f441d has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 2, 2016
bors
added a commit
that referenced
this pull request
Mar 9, 2016
Make errors for unnecessary visibility qualifiers consistent This PR refactors away `syntax::parse::parser::ParsePub` so that unnecessary visibility qualifiers on variant fields are reported not by the parser but by `privacy::SanePrivacyVisitor` (thanks to @petrochenkov's drive-by improvements in #31919). r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31776
r? @nikomatsakis