Clarify memory structure of vectors in documentation #31666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,12 @@ There’s an alternate form of `vec!` for repeating an initial value: | |||
| let v = vec![0; 10]; // ten zeroes | |||
| ``` | |||
|
|
|||
| Vectors store their contents as contiguous arrays of `T` on the heap. This means | |||
| that they must be able to know the size of `T` at compile (that is, how many | |||
There was a problem hiding this comment.
... at compile time (that is, ...
There was a problem hiding this comment.
@rkruppe: Nice catch, fixed!
Closes rust-lang#31554. Contributes to rust-lang#29380.
dirk
force-pushed
the
dirk/clarify-memory-arrangement-in-vec-docs
branch
2 times, most recently
from
3be559a
to
f9fe658
Compare
|
@bors: r+ rollup |
|
📌 Commit f9fe658 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 15, 2016
…t-in-vec-docs, r=steveklabnik Tweak documentation to clarify the structure of `Vec`s as contiguous arrays of items in memory. Closes rust-lang#31554; contributes to rust-lang#29380. r? @steveklabnik
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 16, 2016
…t-in-vec-docs, r=steveklabnik Tweak documentation to clarify the structure of `Vec`s as contiguous arrays of items in memory. Closes rust-lang#31554; contributes to rust-lang#29380. r? @steveklabnik
bors
added a commit
that referenced
this pull request
Feb 17, 2016
…cs, r=steveklabnik Tweak documentation to clarify the structure of `Vec`s as contiguous arrays of items in memory. Closes #31554; contributes to #29380. r? @steveklabnik
| @@ -11,8 +11,8 @@ let v = vec![1, 2, 3, 4, 5]; // v: Vec<i32> | |||
| ``` | |||
|
|
|||
| (Notice that unlike the `println!` macro we’ve used in the past, we use square | |||
| brackets `[]` with `vec!` macro. Rust allows you to use either in either situation, | |||
| this is just convention.) | |||
| brackets `[]` with `vec!` macro. Rust allows you to use either in either | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak documentation to clarify the structure of
Vecs as contiguous arrays of items in memory.Closes #31554; contributes to #29380.
r? @steveklabnik