-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve: improve detection of unused imports and other miscellaneous improvements #31321
Conversation
854b80e
to
ca98356
Compare
Is the first commit a breaking change? Could you add |
I'm not sure if it counts as a breaking change -- it would only cause breakage with |
Ah, yes that makes sense - we don't mark lint changes as breaking. |
lgtm. @petrochenkov would you mind having a look over this? You're probably way more familiar with the details of resolve than I am. |
☔ The latest upstream changes (presumably #31317) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased |
☔ The latest upstream changes (presumably #31338) made this pull request unmergeable. Please resolve the merge conflicts. |
All looks reasonable. |
r+ with a rebase |
@nrc rebased |
@bors: r+ |
📌 Commit 9c166cb has been approved by |
The first commit improves detection of unused imports -- it should have been part of #30325. Right now, the unused import in the changed test would not be reported.
The rest of the commits are miscellaneous, independent clean-ups in resolve that I didn't think warranted individual PRs.
r? @nrc