Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help for E0514 #30622

Closed
wants to merge 1 commit into from
Closed

Add help for E0514 #30622

wants to merge 1 commit into from

Conversation

ticki
Copy link
Contributor

@ticki ticki commented Dec 29, 2015

Part of #30520

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ticki
Copy link
Contributor Author

ticki commented Dec 29, 2015

Fixes #30363

@ticki
Copy link
Contributor Author

ticki commented Jan 1, 2016

r? @arielb1

@rust-highfive rust-highfive assigned arielb1 and unassigned Aatch Jan 1, 2016
@arielb1
Copy link
Contributor

arielb1 commented Jan 2, 2016

This is a little unclear. Maybe "consider recompiling it with this compiler"?

@ticki
Copy link
Contributor Author

ticki commented Jan 2, 2016

Well, it requires the user to explicitly removing the binaries, since they're compiled with an older compiler.

@arielb1
Copy link
Contributor

arielb1 commented Jan 3, 2016

"the binaries" in this case sounds like the intended binary output of this compiler.

@GuillaumeGomez
Copy link
Member

@arielb1: Why not "consider recompiling it with your current rustc version"?

@bors
Copy link
Contributor

bors commented Jan 26, 2016

☔ The latest upstream changes (presumably #31065) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik
Copy link
Member

👍 to @GuillaumeGomez 's suggestion

@arielb1
Copy link
Contributor

arielb1 commented Feb 9, 2016

r=me to that modulo a rebase

@ticki
Copy link
Contributor Author

ticki commented Feb 9, 2016

Sure thing.

@ticki
Copy link
Contributor Author

ticki commented Feb 9, 2016

Rebased.

@ticki
Copy link
Contributor Author

ticki commented Feb 9, 2016

goddammit lints.

@ticki
Copy link
Contributor Author

ticki commented Feb 9, 2016

Rebased again.

@arielb1
Copy link
Contributor

arielb1 commented Feb 11, 2016 

<syntax macros>:2:14: 2:70 error: no method named `span_help` found for type `&'a rustc::session::Session` in the current scope

<syntax macros>:2 { ( $ err ) . span_help ( $ span , & format ! ( $ ( $ message ) * ) ) ; } )

@ticki
Copy link
Contributor Author

ticki commented Feb 11, 2016

The internal API must have changed. Have span_help! been renamed? If so, what is it named now.

@ticki ticki mentioned this pull request Feb 20, 2016
Closed
@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to resubmit with the build errors fixed!

@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 8, 2016
Merged
bors added a commit that referenced this pull request Mar 11, 2016
@bors
Auto merge of #32121 - GuillaumeGomez:help_e0514, r=cmr
2b9438a 
Add help for E0514

I fixed #30622.

r? @arielb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ticki @rust-highfive @arielb1 @GuillaumeGomez @bors @steveklabnik @alexcrichton @Aatch