Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn no_mangle on generic functions #30269

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Dec 8, 2015

Fix #15844.

Should the default be Deny instead?

@rust-highfive
Copy link
Collaborator

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@sanxiyn
Copy link
Member Author

sanxiyn commented Dec 15, 2015

Ping.

@Aatch
Copy link
Contributor

Aatch commented Dec 15, 2015

@bors r+ 55ffc33

@bors
Copy link
Contributor

bors commented Dec 15, 2015

⌛ Testing commit 55ffc33 with merge e4809b0...

@bors
Copy link
Contributor

bors commented Dec 15, 2015

💔 Test failed - auto-win-gnu-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Dec 15, 2015 at 1:17 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-32-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-nopt-t/builds/2417


Reply to this email directly or view it on GitHub
#30269 (comment).

@sanxiyn
Copy link
Member Author

sanxiyn commented Dec 16, 2015

@bors retry

@bors
Copy link
Contributor

bors commented Dec 16, 2015

⌛ Testing commit 55ffc33 with merge c4ae0b1...

@bors
Copy link
Contributor

bors commented Dec 16, 2015

⛄ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request Dec 16, 2015
Fix #15844.

Should the default be Deny instead?
@bors
Copy link
Contributor

bors commented Dec 16, 2015

⌛ Testing commit 55ffc33 with merge d4ffaf6...

@bors bors merged commit 55ffc33 into rust-lang:master Dec 16, 2015
@sanxiyn sanxiyn deleted the no-mangle-generic branch December 16, 2015 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants