Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve public static items across LTO #29656

Merged
merged 1 commit into from
Nov 7, 2015
Merged

Conversation

arcnmx
Copy link
Contributor

@arcnmx arcnmx commented Nov 6, 2015

This is currently done for functions but not public static symbols.

@rust-highfive
Copy link
Collaborator

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

We actually generate a pretty huge number of statics for normal everyday usage, so we may want to also filter by #[no_mangle] as well, but for now this seems fine, thanks!

@bors: r+ 892b50b

@arcnmx
Copy link
Contributor Author

arcnmx commented Nov 6, 2015

Makes sense! I'll see if I can figure that out in a follow-up PR.

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 7, 2015
This is currently done for functions but not public static symbols.
bors added a commit that referenced this pull request Nov 7, 2015
@bors bors merged commit 892b50b into rust-lang:master Nov 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants