Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide span for visit_enum_def #29102

Merged
merged 1 commit into from
Oct 17, 2015
Merged

Provide span for visit_enum_def #29102

merged 1 commit into from
Oct 17, 2015

Conversation

petrochenkov
Copy link
Contributor

Closes #28750
Arm and Generics don't have spans at all, so it's not a visitor's problem, visit_struct_def was fixed in #28816

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ a0f2a59

@bors
Copy link
Contributor

bors commented Oct 17, 2015

⌛ Testing commit a0f2a59 with merge 32a4bd9...

bors added a commit that referenced this pull request Oct 17, 2015
@bors
Auto merge of #29102 - petrochenkov:spanvis, r=alexcrichton
32a4bd9 
Closes #28750
`Arm` and `Generics` don't have spans at all, so it's not a visitor's problem, `visit_struct_def` was fixed in #28816
@bors
Copy link
Contributor

bors commented Oct 17, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit a0f2a59 into rust-lang:master Oct 17, 2015
@bors bors mentioned this pull request Oct 17, 2015
Closed
@petrochenkov petrochenkov deleted the spanvis branch November 22, 2015 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libsyntax/librustc_front: Some visitor methods don't have access to span information
5 participants
@petrochenkov @rust-highfive @alexcrichton @bors @pnkfelix