Refactor coercions/adjustments

[nrc]

@eddyb's preparatory work for DST coercions

r? @nikomatsakis

[nikomatsakis]

@nrc so I reviewed the code. I think it's good, but I have a couple of nits. For one, I think there is a simpler explanation for how AutoderefRef works. This seems to both be logical and fit what trans does, and also makes Box not really a special case. Anyway, I wrote this up here:

nikomatsakis@3f310ae

that patch also includes a simplification to the ExprUseVisitor based on this idea that makes it less hacky. Thoughts?

r+ modulo these nits

[nrc]

Comments inline on your patch. I'm not sure I agree with you explanation 100%, but maybe I misunderstood something last night. It might be that there are just two views on this - the type system's and trans's and they're fundamentally a bit different.

The ExprUseVisitor change looks nice, I can't comment on whether I think it will work :-p

[bors]

☔ The latest upstream changes (presumably #23011) made this pull request unmergeable. Please resolve the merge conflicts.

[nikomatsakis]

@nrc I responded inline. Seems like we see the code a bit differently...but I still stand by my interpretation ;) maybe we can discuss it online (either IRC or vidyo), or maybe @eddyb can weight in as to how he sees it.

[nrc]

@bors r=nikomatsakis 231b1d0

[nrc]

Rebased and added Niko's changes (with a little reformatting).

[bors]

⌛ Testing commit 231b1d0 with merge a3f80bb...

[bors]

💔 Test failed - auto-win-32-opt

[alexcrichton]

@bors: retry

On Mon, Apr 13, 2015 at 5:04 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-32-opt
http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4146

—
Reply to this email directly or view it on GitHub
#24261 (comment).

[bors]

⌛ Testing commit 231b1d0 with merge 958a90c...

[bors]

💔 Test failed - auto-linux-64-nopt-t

[nrc]

@bors r=nikomatsakis b35a587

[bors]

⌛ Testing commit b35a587 with merge 47551b5...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt