std: Add net::IpAddr, destabilize lookup_host #23711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon |
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
This is great! |
|
Hm perhaps! I'm not 100% sure about it as it would silently be passing 0 for flowinfo and scope_id for IPv6 addresses. That being said we already do that elsewhere, so it's not necessarily the end of the world. |
This commits adds back an `IpAddr` enum matching the `SocketAddr` enum, but without a port. The enumeration is `#[unstable]`. The `lookup_host` function and iterator are also destabilized behind a new feature gate due to questions around the semantics of returning `SocketAddr` values.
|
⌛ Testing commit 8165bc1 with merge 2157454... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry On Wed, Mar 25, 2015 at 7:33 PM, bors [email protected] wrote:
|
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 26, 2015
This commits adds back an `IpAddr` enum matching the `SocketAddr` enum, but without a port. The enumeration is `#[unstable]`. The `lookup_host` function and iterator are also destabilized behind a new feature gate due to questions around the semantics of returning `SocketAddr` values.
erickt
added a commit
to erickt/rust
that referenced
this pull request
Mar 26, 2015
This commits adds back an `IpAddr` enum matching the `SocketAddr` enum, but without a port. The enumeration is `#[unstable]`. The `lookup_host` function and iterator are also destabilized behind a new feature gate due to questions around the semantics of returning `SocketAddr` values.
erickt
added a commit
to erickt/rust
that referenced
this pull request
Mar 26, 2015
This commits adds back an `IpAddr` enum matching the `SocketAddr` enum, but without a port. The enumeration is `#[unstable]`. The `lookup_host` function and iterator are also destabilized behind a new feature gate due to questions around the semantics of returning `SocketAddr` values.
bors
added a commit
that referenced
this pull request
Mar 26, 2015
This commits adds back an `IpAddr` enum matching the `SocketAddr` enum, but without a port. The enumeration is `#[unstable]`. The `lookup_host` function and iterator are also destabilized behind a new feature gate due to questions around the semantics of returning `SocketAddr` values.
bors bot
added a commit
to nix-rust/nix
that referenced
this pull request
Apr 11, 2019
1043: Uncomment to_std and from_std methods for IpAddr r=asomers a=rabbott99 These were commented out in 2b60633, apparently because `std::net::IpAddr` had been removed from the standard library. However, `IpAddr` has since been re-added to the standard library (rust-lang/rust#23711) and stabilized (rust-lang/rust#31438), so it seems there is no reason to keep them commented out. Co-authored-by: rabbott99 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds back an
IpAddrenum matching theSocketAddrenum, butwithout a port. The enumeration is
#[unstable]. Thelookup_hostfunction anditerator are also destabilized behind a new feature gate due to questions around
the semantics of returning
SocketAddrvalues.