Fix error message on invalid field names for a struct variant #20084
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
barosl
force-pushed
the
struct-variant-field-err
branch
from
ffd612e to
4e1bba0
Compare
| None => | ||
| format!("structure `{}` has no field named `{}`", | ||
| actual, | ||
| token::get_ident(field.ident.node)) |
There was a problem hiding this comment.
Could you put a block around this format! invocation if you're going to stagger it like that?
barosl
force-pushed
the
struct-variant-field-err
branch
2 times, most recently
from
53e0a53 to
b220925
Compare
barosl
force-pushed
the
struct-variant-field-err
branch
from
b220925 to
c9010bf
Compare
| actual, variant_type.name.as_str(), | ||
| token::get_ident(field.ident.node)) | ||
| } | ||
| None => { |
There was a problem hiding this comment.
it'd have been nice to have a test for this case as well.
There was a problem hiding this comment.
Oh... it's true. I'll add it soon.
There was a problem hiding this comment.
It seems that the case is already provided by the existing test cases(struct-fields-too-many.rs and issue-4736.rs), so I think it would not be necessary to add another one.
There was a problem hiding this comment.
I know it's provided, but it's still nice to have it in the same issue-19922.rs file as a quick proof that this works for the other cases. Sorry, I should have phrased my previous comment better :)
Fixes #19922.