Expansion should explicitly include enum #19812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for removing the std::cmp::Ordering reexport, this needs
to be done to prevent errors like:
```
note: in expansion of #[deriving]
note: expansion site
error: unresolved name `std::cmp::Equal`
\#[deriving(Clone, PartialEq, PartialOrd, Eq, Ord, Show)]
^~~
```
bors
added a commit
that referenced
this pull request
Dec 14, 2014
Expansion should explicitly include enum Reviewed-by: alexcrichton
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 15, 2014
In preparation for [removing the `std::cmp::Ordering` reexport](rust-lang#19253), this needs to be done to prevent errors like: ``` note: in expansion of #[deriving] note: expansion site error: unresolved name `std::cmp::Equal` #[deriving(Clone, PartialEq, PartialOrd, Eq, Ord, Show)] ^~~ ```
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Dec 22, 2014
Part of rust-lang#19253 I would have removed this public reexport in rust-lang#19842, but rust-lang#19812 hadn't merged (and snapshotted) at the time In rust-lang#19407, I changed the codebase to stop utilizing this reexport [breaking-change]
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 22, 2014
Part of rust-lang#19253 I would have removed this public reexport in rust-lang#19842, but rust-lang#19812 hadn't merged (and snapshotted) at the time In rust-lang#19407, I changed the codebase to stop utilizing this reexport [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for removing the
std::cmp::Orderingreexport, this needs to be done to prevent errors like: