Allow adjusting the recursion limit and stop masking overflows #19466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| continue; | ||
| } | ||
|
|
||
| match attr.value_str() { |
There was a problem hiding this comment.
You can shrink this tower a bit with if let.
nikomatsakis
force-pushed
the
recursion-limit
branch
3 times, most recently
from
920f582
to
ca71e1d
Compare
|
@sfackler done |
…prove error reporting to suggest to user how to fix.
nikomatsakis
force-pushed
the
recursion-limit
branch
from
ca71e1d
to
34812b8
Compare
|
I'm surprised this went in without more visibility since it's a source-level interface that has to be specced and maintained. It's also tied to compiler implementation details. |
bors
added a commit
that referenced
this pull request
Aug 25, 2015
See #19466 for background. r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly important for deeply nested types, which generate deeply nested impls. This is a fix for #19318. It's possible we could also improve this particular case not to increment the recursion count, but it's worth being able to adjust the recursion limit anyhow.
cc @jdm
r? @pcwalton