-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move trans, back, driver, and back into a new crate, rustc_trans. #19002
Conversation
❤️ |
@@ -119,7 +117,8 @@ fn runtest(test: &str, cratename: &str, libs: Vec<Path>, externs: core::Externs, | |||
maybe_sysroot: Some(os::self_exe_path().unwrap().dir_path()), | |||
addl_lib_search_paths: RefCell::new(libs), | |||
crate_types: vec!(config::CrateTypeExecutable), | |||
output_types: vec!(write::OutputTypeExe), | |||
output_types: vec!(config | |||
::OutputTypeExe), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extraneous newline?
Might want to update |
Also (this can be a followup of course) we might as well rename |
How much does this affect compile times (by reducing inlining)? |
This looks amazing @nikomatsakis! I think @pcwalton's right in that |
On Sun, Nov 16, 2014 at 12:22:59PM -0800, Alex Crichton wrote:
Yes, I agree, the names are bad, and I liked his suggestions. I'm |
On Sun, Nov 16, 2014 at 07:40:39AM -0800, arielb1 wrote:
I haven't measured compilation time, though I would expect an |
6616f6b
to
ba6c548
Compare
…uces memory usage significantly and opens opportunities for more parallel compilation.
Closing because bors seems confused by this PR. |
Reduces memory usage significantly and opens opportunities for more parallel compilation. This PR was previously #19002 but I closed it because bors didn't seem to recognize the `r+` annotations there.
Reduces memory usage significantly and opens opportunities for more parallel compilation. This PR was previously #19002 but I closed it because bors didn't seem to recognize the `r+` annotations there.
Move trans, back, driver, and back into a new crate, rustc_trans (which probably needs a better name). This is not a principled split per se, though it does make some sense, as the things which have been moved all fall into "back end" territory. The primary motivation is reducing memory usage. Measurements with massif suggest that peak memory usage after this change is 1.5GB. In comparison, measurements on master show a range from 1.8 to 2.5 GB of usage.
r? @brson
cc @alexcrichton
cc #18784