std: Fix env() assert when an environment variable's value contains a '=' char #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Merged. |
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a rust build error from env() assertion failures.
MingW on Windows seems to set some funky environment variables like "=C:=C:\MinGW\msys\1.0\bin" and "!::=::" that cause some assertion failures when trying to build rust. Some of the environment variables may contain '=' chars in their value or even their name!
This small patch avoids the assertion failure. I chose not to hide or sanitize these funky environment variables because they do exist in the system environment. I am also lazy.