Refactor Vec::map_in_place to move code out of PartialVec
#17381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, support zero-sized types.
|
|
|
First off, this is awesome! I definitely think the code is cleaner this way, and I love the work you put into the comments making the algorithm clear. Second, I'm sorry for the delay in having this reviewed -- it seems to've fallen through the cracks. In the future, feel free to ping me or any other member of the team by leaving an "r? @aturon" comment or messaging on IRC if your PR goes unreviewed for more than a day or two. Meantime, I'm handing this off to bors. Nice work! |
bors
added a commit
that referenced
this pull request
Oct 2, 2014
Additionally, support zero-sized types. Now there isn't a safe interface of `PartialVec` anymore, it's just a bare data structure with destructor that assumes you handled everything correctly before.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
fix: ensure that the parent of a SourceRoot cannot be itself fix rust-lang#17378. In `FileSetConfig.map`, different roots might be mapped to the same `root_id` due to deduplication in `ProjectFolders::new`: ```rust // Example from rustup /Users/roife/code/rustup/target/debug/build/rustup-863a063426b56c51/out /Users/roife/code/rustup ``` In `source_root_parent_map`, r-a might encounter paths where their SourceRootId (i.e. `root_id`) is identical, yet one the them is the parent of the another. This situation can cause the `root_id` to be its own parent, potentially leading to an infinite loop. This PR resolves such cases by adding a check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, support zero-sized types.
Now there isn't a safe interface of
PartialVecanymore, it's just a bare data structure with destructor that assumes you handled everything correctly before.